GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/medaitek/mt8186: fix wrong condition of RTC drivers 

We need to report error while rtc_xosc_write() returns false.

TEST=error logs for RTC disappear
BUG=b:202871018

Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Change-Id: I5fdf4de0383ef373dd45e8d8741aa861c9c4bdc6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59653
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
This commit is contained in:
Rex-BC Chen 2021-11-25 15:06:23 +08:00 committed by Felix Held
parent fca89d3d05
commit ffe50fde1a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/mediatek/mt8186/rtc.c
View File

@ -88,7 +88,7 @@ u16 rtc_get_frequency_meter(u16 val, u16 measure_src, u16 window_size)
} }
rtc_read(RTC_OSC32CON, &osc32con); rtc_read(RTC_OSC32CON, &osc32con);
if (rtc_xosc_write((osc32con & ~RTC_XOSCCALI_MASK) | if (!rtc_xosc_write((osc32con & ~RTC_XOSCCALI_MASK) |
(val & RTC_XOSCCALI_MASK))) { (val & RTC_XOSCCALI_MASK))) {
rtc_info("rtc_xosc_write() failed\n"); rtc_info("rtc_xosc_write() failed\n");
return false; return false;