e22f536bf8
When SOC_UART_DEBUG was not set, the boot would hang somwhere in ramstage, as evidenced by POST codes reported from the EC. This was traced to the .set_resources and .enable_resources members of the UART PCI driver being set to NOOP. Although the exact mechanism of failure is not known, this change eliminates the hang. Change-Id: Ic2f3d56a964ec890ebfa1e1a7770f1ae2eb22281 Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc@intel.com> Reviewed-on: https://review.coreboot.org/14771 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
61 lines
1.8 KiB
C
61 lines
1.8 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright (C) 2015 Intel Corp.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
/*
|
|
* The sole purpose of this driver is to avoid BAR to be changed during
|
|
* resource allocation. Since configuration space is just 32 bytes it
|
|
* shouldn't cause any fragmentation.
|
|
*/
|
|
|
|
#include <console/uart.h>
|
|
#include <device/device.h>
|
|
#include <device/pci.h>
|
|
#include <device/pci_ids.h>
|
|
#include <soc/pci_ids.h>
|
|
#include <soc/pci_devs.h>
|
|
|
|
static void aplk_uart_read_resources(struct device *dev)
|
|
{
|
|
pci_dev_read_resources(dev);
|
|
|
|
if ((IS_ENABLED(CONFIG_SOC_UART_DEBUG) &&
|
|
dev->path.pci.devfn == _LPSS_PCI_DEVFN(UART,
|
|
CONFIG_UART_FOR_CONSOLE))) {
|
|
/* will override existing resource. */
|
|
fixed_mem_resource(dev, PCI_BASE_ADDRESS_0,
|
|
CONFIG_CONSOLE_UART_BASE_ADDRESS >> 10, 4, 0);
|
|
}
|
|
}
|
|
|
|
static struct device_operations uart_ops = {
|
|
.read_resources = aplk_uart_read_resources,
|
|
.set_resources = pci_dev_set_resources,
|
|
.enable_resources = pci_dev_enable_resources,
|
|
.init = pci_dev_init,
|
|
.enable = DEVICE_NOOP
|
|
};
|
|
|
|
static const unsigned short uart_ids[] = {
|
|
PCI_DEVICE_ID_APOLLOLAKE_UART0, PCI_DEVICE_ID_APOLLOLAKE_UART1,
|
|
PCI_DEVICE_ID_APOLLOLAKE_UART2, PCI_DEVICE_ID_APOLLOLAKE_UART3,
|
|
0
|
|
};
|
|
|
|
static const struct pci_driver uart_driver __pci_driver = {
|
|
.ops = &uart_ops,
|
|
.vendor = PCI_VENDOR_ID_INTEL,
|
|
.devices = uart_ids
|
|
};
|