182fea717e
Some broken USB mass storage devices send another zero-length packet at the end of the data part of a transfer if the amount of data was evenly divisible by the packet size (which is pretty much always the case for block reads). This packet will get interpreted as the CSW and screw up the MSC state machine. This patch works around this issue by retrying the CSW transfer when it was received as exactly 0 bytes. This is the same mitigation the Linux kernel uses and harmless for correctly behaving devices. Also tighten validation of the CSW a little, making sure we verify the length before we read any fields and checking the signature in addition to the tag. Change-Id: I24f183f27b2c4f0142ba6c4b35b490c5798d0d21 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34485 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| TODO | ||
| dwc2.c | ||
| dwc2.h | ||
| dwc2_private.h | ||
| dwc2_rh.c | ||
| ehci.c | ||
| ehci.h | ||
| ehci_private.h | ||
| ehci_rh.c | ||
| generic_hub.c | ||
| generic_hub.h | ||
| ohci.c | ||
| ohci.h | ||
| ohci_private.h | ||
| ohci_rh.c | ||
| quirks.c | ||
| uhci.c | ||
| uhci.h | ||
| uhci_private.h | ||
| uhci_rh.c | ||
| usb.c | ||
| usb_dev.c | ||
| usbhid.c | ||
| usbhub.c | ||
| usbinit.c | ||
| usbmsc.c | ||
| xhci.c | ||
| xhci.h | ||
| xhci_commands.c | ||
| xhci_debug.c | ||
| xhci_devconf.c | ||
| xhci_events.c | ||
| xhci_private.h | ||
| xhci_rh.c | ||