GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
coreboot-kgpe-d16/util/inteltool
History
Paul Menzel 3402a7fa70 inteltool: Cast to intptr_t instead of uint64_t 
When building inteltool under x86-32, the following warnings are
shown.

    $ gcc --version
    gcc-4.7.real (Debian 4.7.2-15) 4.7.2
    Copyright (C) 2012 Free Software Foundation, Inc.
    This is free software; see the source for copying conditions.  There is NO
    warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
    $ make
    […]
    amb.c: In function ‘amb_read_config32’:
    amb.c:31:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    amb.c:31:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    amb.c: In function ‘amb_read_config16’:
    amb.c:45:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    amb.c:45:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    amb.c: In function ‘amb_read_config8’:
    amb.c:60:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    amb.c:60:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    […]

Nico Huber commented the following [1].

    I don't see those warnings because I build for x86-64. I guess
    they could be fixed by casting to `ptrdiff_t` (from stddef.h)
    instead of `uint64_t`.

And indeed, using `ptrdiff_t` fixes the warning. But as Stefan
Reinauer commented in [2], `intptr_t` is more appropriate as this
is just a pointer and no pointer difference.

So `intptr_t` is taken, which fixes these issues warned about too.

These warnings were introduced in commit »inteltool: Add support for
dumping AMB registers« (4b7b320f) [3].

[1] http://review.coreboot.org/#/c/2996/1//COMMIT_MSG
[2] http://review.coreboot.org/#/c/3002/1/util/inteltool/amb.c
[3] http://review.coreboot.org/525

Change-Id: I2ea1a31dc1e3db129e767d6a9e0433fd75a77d0f
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/3002
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.huber@secunet.com>
2013-04-04 14:24:25 +02:00
..
amb.c inteltool: Cast to intptr_t instead of uint64_t 2013-04-04 14:24:25 +02:00
cpu.c inteltool: Add support for Atom N455 (0x106c0) in CPU MSRs dump 2013-01-25 20:09:24 +01:00
gpio.c inteltool: Add Cougar/Panther Point GPIO defaults 2013-04-01 22:39:30 +02:00
inteltool.8 Cosmetics, whitespace, coding style, partially ident-aided (trivial). 2008-05-14 21:20:55 +00:00
inteltool.c inteltool: Add option to show differences in GPIO setup 2013-04-01 22:39:04 +02:00
inteltool.h inteltool: Add option to show differences in GPIO setup 2013-04-01 22:39:04 +02:00
Makefile inteltool: Allow to override Makefile variables 2013-04-01 22:40:45 +02:00
memory.c inteltool: Use ll instead of l as the length modifier for uint64_t 2013-04-03 11:13:29 +02:00
pcie.c inteltool: add support for 946GZ and 946PL 2012-10-19 10:27:53 +02:00
powermgt.c inteltool: Support PM registers on Cougar/Panther Point 2013-04-01 21:00:16 +02:00
rootcmplx.c inteltool: Add Cougar/Panther Point IDs to rootcmplx.c 2013-03-30 18:17:08 +01:00