3f1de9add9
Fix DSM function 0 (query function) to correctly report function support for its revision. Revision 1 should return 0x3 because I2C HID supports only 1 additional function. All other revisions should return 0. BUG=b:170862147 BRANCH=Zork TEST=ensure no dmesg errors; disassemble and verify SSDT Signed-off-by: Josie Nordrum <JosieNordrum@google.com> Change-Id: Iee082ef5cf44c4cf7ab304345af56f3b5173ca56 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46429 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
50 lines
1.5 KiB
C
50 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
|
|
#include <acpi/acpigen.h>
|
|
#include <acpi/acpigen_dsm.h>
|
|
|
|
/* ------------------- I2C HID DSM ---------------------------- */
|
|
|
|
#define ACPI_DSM_I2C_HID_UUID "3CDFF6F7-4267-4555-AD05-B30A3D8938DE"
|
|
|
|
/* I2C HID currently supports revision 1 only, for which, only 1 additional
|
|
* function is supported. Thus, the query function should return 0x3:
|
|
* bit 0 = additional function supported
|
|
* bit 1 = function with index 1 supported
|
|
* All other revisions do not support additional functions and hence return 0
|
|
*/
|
|
|
|
static void i2c_hid_func0_cb(void *arg)
|
|
{
|
|
/* ToInteger (Arg1, Local2) */
|
|
acpigen_write_to_integer(ARG1_OP, LOCAL2_OP);
|
|
/* If (LEqual (Local2, 0x1)) */
|
|
acpigen_write_if_lequal_op_int(LOCAL2_OP, 0x1);
|
|
/* Return (Buffer (One) { 0x3 }) */
|
|
acpigen_write_return_singleton_buffer(0x3);
|
|
acpigen_pop_len(); /* Pop : If */
|
|
/* Else */
|
|
acpigen_write_else();
|
|
/* Return (Buffer (One) { 0x0 }) */
|
|
acpigen_write_return_singleton_buffer(0x0);
|
|
acpigen_pop_len(); /* Pop : Else */
|
|
}
|
|
|
|
static void i2c_hid_func1_cb(void *arg)
|
|
{
|
|
struct dsm_i2c_hid_config *config = arg;
|
|
acpigen_write_return_byte(config->hid_desc_reg_offset);
|
|
}
|
|
|
|
static void (*i2c_hid_callbacks[2])(void *) = {
|
|
i2c_hid_func0_cb,
|
|
i2c_hid_func1_cb,
|
|
};
|
|
|
|
void acpigen_write_dsm_i2c_hid(struct dsm_i2c_hid_config *config)
|
|
{
|
|
acpigen_write_dsm(ACPI_DSM_I2C_HID_UUID, i2c_hid_callbacks,
|
|
ARRAY_SIZE(i2c_hid_callbacks), config);
|
|
}
|
|
|
|
/* ------------------- End: I2C HID DSM ------------------------- */
|