coreboot-kgpe-d16

History

Michael Niewöhner e10efa3a03 util/apcb_edit: fix handling of binary SPD files Passing binary SPD files to apcb_edit can lead to an encoding error, since the files were read in text mode. To fix this, read SPD files always in binary mode and only decode them, when `--hex` is set. Tested by comparing output files from the same SPDs in both, binary and hex mode. Change-Id: I6b75a9e1234e71667bdc8cb4eb10daf8c0ac3c17 Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44778 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Nico Huber <nico.h@gmx.de>	2020-09-08 05:44:28 +00:00
..
README	…
apcb_edit.py	util/apcb_edit: fix handling of binary SPD files	2020-09-08 05:44:28 +00:00

Michael Niewöhner e10efa3a03 util/apcb_edit: fix handling of binary SPD files

Passing binary SPD files to apcb_edit can lead to an encoding error,
since the files were read in text mode. To fix this, read SPD files
always in binary mode and only decode them, when `--hex` is set.

Tested by comparing output files from the same SPDs in both, binary and
hex mode.

Change-Id: I6b75a9e1234e71667bdc8cb4eb10daf8c0ac3c17
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44778
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>

2020-09-08 05:44:28 +00:00

README

…

apcb_edit.py

util/apcb_edit: fix handling of binary SPD files

2020-09-08 05:44:28 +00:00

README

The necessary tools for building APCBs are not available for use by coreboot.
This tool allows patching an existing APCB binary with specific SPDs
and GPIO selection pins.