coreboot-kgpe-d16/src
Kerry Sheh 8660a1aa56 Fix multipleVGA cards resource conflict on Windows
If multiple VGA-compatible legacy graphic cards decode the IO range
3B0-3BB, 3C0-3DF and MEM range A00000-BFFFF.
Windows 7 complain a resource conflict, so only one VGA card can
works at the same time.

There is a discussion in coreboot mail list before,
please reference thread: "how to prevent legacy resource conflictwith   multipleVGA cards"
http://www.coreboot.org/pipermail/coreboot/2010-October/061508.html

Linux using VGA Arbiter module(vgaarb) to resolve this resource conflict,
Please see the following linux dmesg log, more information can be found in
Linux source dir Documentation/vgaarbiter.txt.
But it seems that windows don't dealwith this conflict.
~# dmesg | grep -i vgaarb
[    0.774076] vgaarb: device added: PCI:0000:00:01.0,decodes=io+mem,owns=io+mem
[    0.776065] vgaarb: device added: PCI:0000:01:00.0,decodes=io+mem,owns=none,l
[    0.780051] vgaarb: loaded
[    0.784049] vgaarb: bridge control possible 0000:01:00.0
[    0.788050] vgaarb: bridge control possible 0000:00:01.0

For the second legacy graphic device, coreboot already disabled the
IO and MEM decode in function set_vga_bridge_bits().
But it will be enabled again in function pci_set_resource(),
if the second legacy vga-compatible graphic device take any IO/MEM resources.

Following log printed by enable_resources() shows the problem:
...snip...
PCI: 00:00.0 cmd <- 06
PCI: 00:01.0 subsystem <- 1022/1410
PCI: 00:01.0 cmd <- 07                <== The first graphic device
PCI: 00:01.1 subsystem <- 1022/1410
PCI: 00:01.1 cmd <- 02
PCI: 00:02.0 bridge ctrl <- 0003
PCI: 00:02.0 cmd <- 07
...snip...
PCI: 01:00.0 cmd <- 03                <== The second graphic device
PCI: 01:00.1 cmd <- 02
PCI: 02:00.0 cmd <- 02
PCI: 03:00.0 cmd <- 03
done.
...snip...


The IO & MEM decoding on the second vga graphic device should be disabled.
Please reference PCI spec. section 3.10 in detail.
set_vga_bridge_bits() would do this work for us, it did the right thing,
but was put to the wrong place, the setting would be overwritten by
assign_resources() later.

In order to make sure the set_vga_bridge_bits() setting not be
overwritten by others, moving the call of set_vga_bridge_bits()
to the end of dev_configure(), instead of at the beginning.

This patch resolved the dual graphic cards resource conflict in windows7,
multiple vga-compatible graphic cards can work together in windows7.


Signed-off-by: Kerry Sheh <shekairui@gmail.com>
Signed-off-by: Kerry Sheh <kerry.she@amd.com>
Change-Id: I0de5e3761b51e2723d9c1dc0c39fff692e3a779d
Reviewed-on: http://review.coreboot.org/489
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marcj303@gmail.com>
2012-02-07 00:32:52 +01:00
..
arch/x86 Move SeaBIOS output out of coreboot source tree 2012-02-07 00:21:03 +01:00
boot selfboot: Don't include unneeded ip_checksum.h 2011-11-08 21:21:55 +01:00
console trivial:change the value type of POST_PORT in Kconfig from int to hex 2011-12-26 08:52:07 +01:00
cpu post code: Replaced hard-coded post code with macro 2012-01-23 22:50:56 +01:00
devices Fix multipleVGA cards resource conflict on Windows 2012-02-07 00:32:52 +01:00
drivers adm1026: removed prototype 2012-01-21 18:48:03 +01:00
ec X60/T60: Add option to enable/disable bluetooth 2012-01-31 18:03:40 +01:00
include Add OPROM mapping support to coreboot 2012-02-07 00:09:58 +01:00
lib lib: add ram_check_nodie 2012-01-12 13:26:29 +01:00
mainboard Inagua: Indent and wihtespace cleanup 2012-02-07 00:25:07 +01:00
northbridge Add Intel i5000 Memory Controller Hub 2012-02-02 13:49:33 +01:00
pc80 vga: removed inclusion of .c files 2012-01-27 20:07:00 +01:00
southbridge i3100: configure pci irqs 2012-02-02 16:01:47 +01:00
superio SIO: condition compile Nuvoton WPCM450 early_init.c 2012-02-05 17:45:08 +01:00
vendorcode SB700 southbridge: AMD SB700/SP5100 southbridge CIMX code 2012-02-02 15:05:36 +01:00
Kconfig Move SeaBIOS output out of coreboot source tree 2012-02-07 00:21:03 +01:00
Kconfig.deprecated_options Unify ID_SECTION_OFFSET and mark it deprecated 2012-01-18 11:21:39 +01:00