d61350c403
Our realloc() works (somewhat suboptimally) by free()ing the existing allocation and then reallocating it wherever it fits. If there was free space before the old location, this means the new allocation may be before the old one, and if the free space block is smaller than the old allocation it may overlap. Thus, we should be moving memmove() instead of memcpy() to move the block over. This is not a problem in practice since all our existing memcpy()s are simple iterate and copy front to back implementations which are safe for overlaps when the destination is in front of the source. but it's still the more correct thing to do (in case we ever change our memcpy()s to do something more advanced or whatever). Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I35f77a94b7a72c01364ee7eecb5c3ff5ecde57f6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40028 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> |
||
|---|---|---|
| .. | ||
| Makefile.inc | ||
| args.c | ||
| console.c | ||
| coreboot.c | ||
| ctype.c | ||
| die.c | ||
| exec.c | ||
| fmap.c | ||
| getopt_long.c | ||
| hexdump.c | ||
| ipchecksum.c | ||
| lib.c | ||
| libgcc.c | ||
| malloc.c | ||
| memory.c | ||
| printf.c | ||
| qsort.c | ||
| rand.c | ||
| readline.c | ||
| string.c | ||
| strlcpy.c | ||
| sysinfo.c | ||
| time.c | ||