Furquan Shaikh a00c7774d8 soc/intel/common: Disable GPEs just before enabling SMIs ... Call to pmc_disable_all_gpe is required before enabling SMIs to ensure that we do not end up in a recursive SMI handler loop as mentioned in change 74145f7 (intel/common/pmc: Disable all GPEs during pmc_init). Thus, this call was added at the end of pmc_fill_power_state as we want to ensure that all the GPE registers are backed up before being cleared for identifying the wake source in ramstage. This resulted in a side-effect on APL where pmc_fixup_power_state was called much later in the boot process. Even though we have got rid of pmc_fixup_power_state, this change moves the call to pmc_disable_all_gpe to happen just before enabling SMIs. This helps to keep the disabling of GPEs logically before the enabling of SMIs and any clean ups that happen in pmc or soc-specific code should not affect the state of GPEs. BUG=b:110836465 TEST=Verified that wake sources are correctly identified on KBL and APL. Also, no SMI handler issues observed when resuming. Change-Id: I122a8118edcec117f25beee71a23c0a44ae862ed Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/27251 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>		2018-06-28 05:00:12 +00:00
..
acpi	chromeec platforms: Update ACPI thermal event handler call	2018-05-01 15:54:55 +00:00
basecode	soc/intel/common: Make infrastructure ready for Intel common stage files	2018-06-21 15:54:48 +00:00
block	soc/intel/common: Disable GPEs just before enabling SMIs	2018-06-28 05:00:12 +00:00
pch	soc/intel/common/pch: Add pch lockdown code	2018-06-07 21:58:19 +00:00
acpi.h	soc/intel/common/block: Common ACPI	2017-09-08 19:01:04 +00:00
acpi_wake_source.c	compiler.h: add __weak macro	2018-04-24 14:37:59 +00:00
hda_verb.c
hda_verb.h
Kconfig	soc/intel/common: Make infrastructure ready for Intel common stage files	2018-06-21 15:54:48 +00:00
Makefile.inc	soc/intel/common/pch: Make infrastructure ready for pch common code	2018-06-06 06:16:49 +00:00
mma.c
mma.h
nhlt.c
reset.c	soc/intel/common/block: Common ACPI	2017-09-08 19:01:04 +00:00
smbios.c
smbios.h
tpm_tis.c	security/tpm: Change TPM naming for different layers.	2018-01-18 01:45:35 +00:00
util.c
util.h
vbt.c	drivers/intel/gma, soc/intel/common: improve cooperation	2018-05-09 13:48:07 +00:00
vbt.h	drivers/intel/gma, soc/intel/common: improve cooperation	2018-05-09 13:48:07 +00:00