coreboot-kgpe-d16/payloads
Yidi Lin 8610dd5022 libpayload: usbmsc: Prevent usbdisk_remove() from being called twice
When removing SD card from USB card reader, the USB MSC stack does
not detach the device immediately. Instead, the USB MSC stack calls
usbdisk_remove() and calls usb_msc_destroy() after several pollings.
It results in usbdisk_remove() being called twice.

Since the usbmsc_inst_t instance is freed after first usbdisk_remove()
call, the second call invokes an invalid usbmsc_inst_t instance and
causes exception in CPU.

This patch prevents usbdisk_remove() from being called twice by setting
usbdisk_created to zero.

BUG=b:239492347
TEST=insert an empty SD card into the USB card reader then remove
     the SD card. AP firmware does not crash.

Change-Id: I0675e9fde3e770d63dd0047928356a204245ef18
Signed-off-by: Yidi Lin <yidilin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66449
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
2022-08-12 17:14:54 +00:00
..
coreinfo payloads/coreinfo/coreboot_module.c: Remove 'break' after 'return' 2022-05-16 02:56:31 +00:00
external payloads/tianocore: Remove the option for CorebootPayloadPkg 2022-08-07 19:48:17 +00:00
libpayload libpayload: usbmsc: Prevent usbdisk_remove() from being called twice 2022-08-12 17:14:54 +00:00
linuxcheck
nvramcui payloads/nvramcui/nvramcui.c: Reformat code 2022-05-16 02:49:50 +00:00
Kconfig payloads/external: Add support for coreDOOM payload 2022-05-28 15:01:47 +00:00
Makefile.inc payloads/external: Add support for coreDOOM payload 2022-05-28 15:01:47 +00:00