coreboot-kgpe-d16/payloads/libpayload/drivers/video
Nico Huber 425973cf42 libpayload: Always use virtual pointers in struct sysinfo_t
We had mixed virtual and physical pointers in struct sysinfo_t. Some
being virtual by accident which led to problems when we tried to
reinitialize lib_sysinfo after relocating FILO (to get intentionally
virtual pointers valid again). I guess this didn't cause much trouble
before, as lib_get_sysinfo() was always called with physical addresses
being equal to their virtual counterparts.

For FILO, two possibilities seem practical: Either, have all pointers in
struct sysinfo_t physical, so relocation doesn't hurt. Or, have all
pointers virtual and call lib_get_sysinfo() again after relocation.

This patch goes the latter way, changing the following pointers for
situations where virtual pointers differ from physical:
  .extra_version
  .build
  .compile_time
  .compile_by
  .compile_host
  .compile_domain
  .compiler
  .linker
  .assembler
  .cb_version
  .vdat_addr
  .tstamp_table
  .cbmem_cons
  .mrc_cache
We could also just correct the accidentally virtual pointers. But, IMO,
this would lower the risk of future confusion.

Note 1: Looks like .version gets never set.

Note 2: .option_table and .framebuffer were virtual pointers but treated
        like physical ones. Even in FILO, this led to no problems as
        they were set before relocation.

Change-Id: I4c456f56f049d9f8fc40e62520b1d8ec3dad48f8
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: http://review.coreboot.org/1855
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
2012-11-15 18:51:37 +01:00
..
corebootfb.c libpayload: Always use virtual pointers in struct sysinfo_t 2012-11-15 18:51:37 +01:00
font8x16.c Document all of the external code we use in libpayload (trivial). 2008-08-11 20:34:50 +00:00
font8x16.h Various small consistency fixes (trivial): 2008-04-11 18:01:50 +00:00
geodelx.c libpayload: fix garbage on screen with Geode-LX VGA 2010-08-18 21:23:27 +00:00
vga.c Add coreboot framebuffer support to libpayload 2010-03-25 18:56:26 +00:00
video.c libpayload: Add a function to retrieve the rows and cols of the video console. 2012-11-09 19:02:26 +01:00