GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
coreboot-kgpe-d16/payloads/external
History
Nicholas Chin c217f31d0b payloads/tianocore: Fix unclean working directory detection 
After commit ae48b42683 (payloads/tianocore: Init submodules),
Tianocore's Makefile no longer detects an unclean working directory and
thus always performs a `git checkout`, overwriting any uncommited
changes made in the cloned sources.

The change of "clean" to "dirty" effectively inverts the logic of the
if-else condition, which would normally swap the two possible code paths
of the branch. However, since `git status` outputs multiple lines, most
of which do not contain "clean", the -v option (select non-matching
lines) causes grep to always match at least 1 line and thus return
success.  This causes the if-else branch containing the `git checkout`
to always be taken regardless of the state of the working tree, masking
the issue of the inverted logic.  Removing the -v option addresses both
of these issues and restores the intended behavior of the if-else block.

TEST:
1) Build coreboot successfully with the Tianocore UefiPayloadPkg option.
2) Make a change in the cloned Tianocore sources that results in an
   unclean working directory and check for the "Working directory not
clean" message when building coreboot.

Change-Id: Icd4952b40c147d0fba676089ced5a8b59b93ad50
Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64608
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@tutanota.com>
2022-05-28 14:57:07 +00:00
..
BOOTBOOT payloads/external: add support for BOOTBOOT payload 2020-09-26 23:08:07 +00:00
depthcharge payloads/depthcharge: enable LP_CHROMEOS in depthcharge 2022-04-19 13:03:00 +00:00
FILO payloads: FILO: Hook up autoboot options 2021-07-19 09:20:52 +00:00
GRUB2 payloads/external: Add more option related to SeaBIOS and GRUB2 2022-05-24 12:58:52 +00:00
iPXE payloads/iPXE: Update stable version from 2019.3 to to 2022.1 2022-03-22 21:02:59 +00:00
linux arch/riscv: Enable FIT support 2019-08-08 13:03:59 +00:00
LinuxBoot payloads/LinuxBoot: Fix u-root branch 2022-04-13 14:30:37 +00:00
Memtest86Plus payloads/external: Fix up SPDX license headers 2020-11-22 22:19:19 +00:00
SeaBIOS payloads/external: Add more option related to SeaBIOS and GRUB2 2022-05-24 12:58:52 +00:00
skiboot payloads/external: add skiboot (for QEMU/Power9) 2022-02-16 15:39:19 +00:00
tianocore payloads/tianocore: Fix unclean working directory detection 2022-05-28 14:57:07 +00:00
tint tint: introduce the new tint build system with checksum verification 2021-04-16 06:49:18 +00:00
U-Boot payloads/U-Boot: Fix various build errors 2021-12-14 16:13:06 +00:00
Yabits payloads/external: Fix up SPDX license headers 2020-11-22 22:19:19 +00:00
.gitignore payloads/external: add skiboot (for QEMU/Power9) 2022-02-16 15:39:19 +00:00
Makefile.inc payloads/external: Add more option related to SeaBIOS and GRUB2 2022-05-24 12:58:52 +00:00