0b5678f21f
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: do not use assignment in if condition
ERROR: trailing statements should be on next line
ERROR: Macros with complex values should be enclosed in parentheses
ERROR: switch and case should be at the same indent
WARNING: char * array declaration might be better as static const
WARNING: else is not generally useful after a break or return
WARNING: storage class should be at the beginning of the declaration
WARNING: void function return statements are not generally useful
WARNING: break is not useful after a goto or return
WARNING: Single statement macros should not use a do {} while (0) loop
WARNING: sizeof *t should be sizeof(*t)
WARNING: Comparisons should place the constant on the right side of the test
TEST=Build and run on Galileo Gen2
Change-Id: I39d49790c5eaeedec5051e1fab0b1279275f6e7f
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18865
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
67 lines
1.5 KiB
C
67 lines
1.5 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <smp/node.h>
|
|
#include <arch/bootblock_romcc.h>
|
|
#include <pc80/mc146818rtc.h>
|
|
#include <halt.h>
|
|
|
|
static const char *get_fallback(const char *stagelist)
|
|
{
|
|
while (*stagelist)
|
|
stagelist++;
|
|
return ++stagelist;
|
|
}
|
|
|
|
static void main(unsigned long bist)
|
|
{
|
|
u8 boot_mode;
|
|
const char *default_filenames =
|
|
"normal/romstage\0fallback/romstage";
|
|
|
|
if (boot_cpu()) {
|
|
bootblock_mainboard_init();
|
|
|
|
#if CONFIG_USE_OPTION_TABLE
|
|
sanitize_cmos();
|
|
#endif
|
|
boot_mode = do_normal_boot();
|
|
} else {
|
|
|
|
/* Questionable single byte read from CMOS.
|
|
* Do not add any other CMOS access in the
|
|
* bootblock for AP CPUs.
|
|
*/
|
|
boot_mode = boot_use_normal(cmos_read(RTC_BOOT_BYTE));
|
|
}
|
|
|
|
char *normal_candidate = (char *)walkcbfs("coreboot-stages");
|
|
|
|
if (!normal_candidate)
|
|
normal_candidate = default_filenames;
|
|
|
|
unsigned long entry;
|
|
|
|
if (boot_mode) {
|
|
entry = findstage(normal_candidate);
|
|
if (entry)
|
|
call(entry, bist);
|
|
}
|
|
|
|
entry = findstage(get_fallback(normal_candidate));
|
|
if (entry)
|
|
call(entry, bist);
|
|
|
|
/* duh. we're stuck */
|
|
halt();
|
|
}
|