f5ca922c87
The option to specify a binary file name was added later for platforms that do not provide microcode updates in our blobs repository. Alas, it wasn't visible what platforms these are. And if you specified a file for a platform that already had one, they were all included together. Make it visible which platforms don't provide binaries with the new con- figs MICROCODE_BLOB_NOT_IN_BLOB_REPO, MICROCODE_BLOB_NOT_HOOKED_UP and MICROCODE_BLOB_UNDISCLOSED. Based on that we can decide if we want to include binaries by default or explicitly show that no files are inclu- ded (default to CPU_MICROCODE_CBFS_NONE). Also split CPU_MICROCODE_CBFS_GENERATE into the more explicit CPU_MICROCODE_CBFS_DEFAULT_BINS and CPU_MICROCODE_CBFS_EXTERNAL_BINS. And clean up the visibility of options: Don't show CBFS related options on platforms that don't support it and don't show external file options if the platform uses special rules for multiple files (CPU_MICROCODE_ MULTIPLE_FILES). Change-Id: Ib403402e240d3531640a62ce93b7a93b4ef6ca5e Signed-off-by: Nico Huber <nico.huber@secunet.com> Reviewed-on: https://review.coreboot.org/c/29934 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
69 lines
2.8 KiB
Makefile
69 lines
2.8 KiB
Makefile
################################################################################
|
|
## Subdirectories
|
|
################################################################################
|
|
subdirs-y += allwinner
|
|
subdirs-y += amd
|
|
subdirs-y += armltd
|
|
subdirs-y += imgtec
|
|
subdirs-y += intel
|
|
subdirs-y += ti
|
|
subdirs-y += via
|
|
subdirs-$(CONFIG_ARCH_X86) += x86
|
|
subdirs-$(CONFIG_CPU_QEMU_X86) += qemu-x86
|
|
|
|
$(eval $(call create_class_compiler,cpu_microcode,x86_32))
|
|
################################################################################
|
|
## Rules for building the microcode blob in CBFS
|
|
################################################################################
|
|
|
|
ifneq ($(CONFIG_CPU_MICROCODE_MULTIPLE_FILES), y)
|
|
cbfs-files-$(CONFIG_USE_CPU_MICROCODE_CBFS_BINS) += cpu_microcode_blob.bin
|
|
endif
|
|
|
|
ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y)
|
|
cbfs-files-y += cpu_microcode_blob.bin
|
|
cpu_microcode_blob.bin-file = $(objgenerated)/microcode.bin
|
|
|
|
$(objgenerated)/microcode.bin: $(call strip_quotes,$(CONFIG_CPU_MICROCODE_HEADER_FILES))
|
|
echo " util/scripts/ucode_h_to_bin.sh $(objgenerated)/microcode.bin \"$(CONFIG_CPU_MICROCODE_HEADER_FILES)\""
|
|
util/scripts/ucode_h_to_bin.sh $(objgenerated)/microcode.bin $(CONFIG_CPU_MICROCODE_HEADER_FILES)
|
|
endif
|
|
|
|
ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_BINS),y)
|
|
cpu_microcode_bins := $(call strip_quotes,$(CONFIG_CPU_UCODE_BINARIES))
|
|
endif
|
|
# otherwise `cpu_microcode_bins` should be filled by platform makefiles
|
|
|
|
# We just mash all microcode binaries together into one binary to rule them all.
|
|
# This approach assumes that the microcode binaries are properly padded, and
|
|
# their headers specify the correct size. This works fairly well on isolatied
|
|
# updates, such as Intel and some AMD microcode, but won't work very well if the
|
|
# updates are wrapped in a container, like AMD's microcode update container. If
|
|
# there is only one microcode binary (i.e. one container), then we don't have
|
|
# this issue, and this rule will continue to work.
|
|
$(obj)/cpu_microcode_blob.bin: $$(wildcard $$(cpu_microcode_bins))
|
|
for bin in $(cpu_microcode_bins); do \
|
|
if [ ! -f "$$bin" ]; then \
|
|
echo "Microcode error: $$bin does not exist"; \
|
|
NO_MICROCODE_FILE=1; \
|
|
fi; \
|
|
done; \
|
|
if [ -n "$$NO_MICROCODE_FILE" ]; then \
|
|
if [ -z "$(CONFIG_USE_BLOBS)" ] && [ -n "$(CONFIG_CPU_MICROCODE_CBFS_DEFAULT_BINS)" ]; then \
|
|
echo "Try enabling binary-only repository in Kconfig 'General setup' menu."; \
|
|
fi; \
|
|
false; \
|
|
fi
|
|
$(if $^,,false) # fail if no file is given at all
|
|
@printf " MICROCODE $(subst $(obj)/,,$(@))\n"
|
|
@echo $(cpu_microcode_bins)
|
|
cat $^ > $@
|
|
|
|
cpu_microcode_blob.bin-file ?= $(obj)/cpu_microcode_blob.bin
|
|
cpu_microcode_blob.bin-type := microcode
|
|
|
|
ifneq ($(CONFIG_CPU_MICROCODE_CBFS_LOC),)
|
|
cpu_microcode_blob.bin-COREBOOT-position := $(CONFIG_CPU_MICROCODE_CBFS_LOC)
|
|
else
|
|
cpu_microcode_blob.bin-align := 16
|
|
endif
|