88991caf00
When getting the address of a structure's member that is not on offset 0, GCC9+ assumes that the address can never be NULL. However the code relied on the fact that it can be NULL by letting the pointer intentionally overflow. Manually calculate the address using uintptr_t. This allows to gracefully terminate the list_for_each MACRO instead of crashing at the end of the list. Tested on qemu-system-arm: coreboot no longer crashed in the devicetree parser and is able to boot Linux 5.5. Change-Id: I0d569b59a23d1269f8575fcbbe92a5a6816aa1f7 Signed-off-by: Patrick Rudolph <siro@das-labor.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44573 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
25 lines
951 B
C
25 lines
951 B
C
/* Taken from depthcharge: src/base/list.h */
|
|
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#ifndef __LIST_H__
|
|
#define __LIST_H__
|
|
|
|
struct list_node {
|
|
struct list_node *next;
|
|
struct list_node *prev;
|
|
};
|
|
|
|
// Remove list_node node from the doubly linked list it's a part of.
|
|
void list_remove(struct list_node *node);
|
|
// Insert list_node node after list_node after in a doubly linked list.
|
|
void list_insert_after(struct list_node *node, struct list_node *after);
|
|
// Insert list_node node before list_node before in a doubly linked list.
|
|
void list_insert_before(struct list_node *node, struct list_node *before);
|
|
|
|
#define list_for_each(ptr, head, member) \
|
|
for ((ptr) = container_of((head).next, typeof(*(ptr)), member); \
|
|
(uintptr_t)ptr + (uintptr_t)offsetof(typeof(*(ptr)), member); \
|
|
(ptr) = container_of((ptr)->member.next, \
|
|
typeof(*(ptr)), member))
|
|
|
|
#endif /* __LIST_H__ */
|