d6865222c8
Because we had no stack on romcc boards, we had a separate, not as powerful clone of printk: print_*. Back in the day, like more than half a decade ago, we migrated a lot of boards to printk, but we never cleaned up the existing code to be consistent. Instead, we worked around the problem with a very messy console.h (nowadays the mess is hidden in romstage_console.c and early_print.h) This patch cleans up the generic code pieces to use printk() on all non-ROMCC boards. Our two remaining ROMCC boards are fixed up in this commit: bifferos/bifferboard and dmp/vortex86ex. Change-Id: I16676eeabe5c892c8e3c9f3c0cd3bae2e8fd74b6 Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Reviewed-on: http://review.coreboot.org/8115 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-by: Andrew Wu <arw@dmp.com.tw> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
79 lines
1.8 KiB
C
79 lines
1.8 KiB
C
/*
|
|
* This code is derived from the Opteron boards' debug.c.
|
|
* It should go away either there or here, depending what fits better.
|
|
*/
|
|
|
|
static void dump_spd_registers(const struct mem_controller *ctrl)
|
|
{
|
|
int i;
|
|
printk(BIOS_DEBUG, "\n");
|
|
for(i = 0; i < 4; i++) {
|
|
unsigned device;
|
|
device = ctrl->channel0[i];
|
|
if (device) {
|
|
int j;
|
|
printk(BIOS_DEBUG, "dimm: %02x.0: %02x", i, device);
|
|
for(j = 0; j < 256; j++) {
|
|
int status;
|
|
unsigned char byte;
|
|
if ((j & 0xf) == 0)
|
|
printk(BIOS_DEBUG, "\n%02x: ", j);
|
|
status = spd_read_byte(device, j);
|
|
if (status < 0) {
|
|
printk(BIOS_DEBUG, "bad device\n");
|
|
break;
|
|
}
|
|
byte = status & 0xff;
|
|
printk(BIOS_DEBUG, "%02x ", byte);
|
|
}
|
|
printk(BIOS_DEBUG, "\n");
|
|
}
|
|
device = ctrl->channel1[i];
|
|
if (device) {
|
|
int j;
|
|
printk(BIOS_DEBUG, "dimm: %02x.1: %02x", i, device);
|
|
for(j = 0; j < 256; j++) {
|
|
int status;
|
|
unsigned char byte;
|
|
if ((j & 0xf) == 0)
|
|
printk(BIOS_DEBUG, "\n%02x: ");
|
|
status = spd_read_byte(device, j);
|
|
if (status < 0) {
|
|
printk(BIOS_DEBUG, "bad device\n");
|
|
break;
|
|
}
|
|
byte = status & 0xff;
|
|
printk(BIOS_DEBUG, "%02x ", byte);
|
|
}
|
|
printk(BIOS_DEBUG, "\n");
|
|
}
|
|
}
|
|
}
|
|
|
|
#if 0
|
|
void dump_spd_registers(void)
|
|
{
|
|
unsigned device;
|
|
device = SMBUS_MEM_DEVICE_START;
|
|
printk(BIOS_DEBUG, "\n");
|
|
while(device <= SMBUS_MEM_DEVICE_END) {
|
|
int status = 0;
|
|
int i;
|
|
printk(BIOS_DEBUG, "dimm %02x", device);
|
|
for(i = 0; (i < 256) && (status == 0); i++) {
|
|
unsigned char byte;
|
|
if ((i % 20) == 0) {
|
|
printk(BIOS_DEBUG, "\n%3d: ", i);
|
|
}
|
|
status = smbus_read_byte(device, i, &byte);
|
|
if (status != 0) {
|
|
printk(BIOS_DEBUG, "bad device\n");
|
|
continue;
|
|
}
|
|
printk(BIOS_DEBUG, "%02x ", byte);
|
|
}
|
|
device += SMBUS_MEM_DEVICE_INC;
|
|
printk(BIOS_DEBUG, "\n");
|
|
}
|
|
}
|
|
#endif
|