0187380875
The Clang Static Analyzer warns about an unused assignment, when
building the image for the Lenovo X60.
```
src/arch/x86/gdt.c:39:6: warning: Value stored to 'num_gdt_bytes' \
during its initialization is never read
u16 num_gdt_bytes = (uintptr_t)&gdt_end - (uintptr_t)&gdt;
^~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
If `CONFIG_RELOCATABLE_RAMSTAGE` is selected, the function returns
before the assignment is used. So, move the assignment below the if
statement.
Change-Id: Ibcb8bce743d8cb3625647804816fb97f937dc429
Found-by: clang version 4.0.1-6 (tags/RELEASE_401/final), Debian Sid/unstable
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/21957
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Martin Roth <martinroth@google.com>
65 lines
1.6 KiB
C
65 lines
1.6 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright (C) 2008-2009 coresystems GmbH
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <types.h>
|
|
#include <string.h>
|
|
#include <compiler.h>
|
|
#include <cbmem.h>
|
|
#include <console/console.h>
|
|
#include <cpu/x86/gdt.h>
|
|
|
|
/* i386 lgdt argument */
|
|
struct gdtarg {
|
|
u16 limit;
|
|
#ifdef __x86_64__
|
|
u64 base;
|
|
#else
|
|
u32 base;
|
|
#endif
|
|
} __packed;
|
|
|
|
/*
|
|
* Copy GDT to new location and reload it.
|
|
* FIXME: We only do this for BSP CPU.
|
|
*/
|
|
static void move_gdt(int is_recovery)
|
|
{
|
|
void *newgdt;
|
|
u16 num_gdt_bytes;
|
|
struct gdtarg gdtarg;
|
|
|
|
/* ramstage is already in high memory. No need to use a new gdt. */
|
|
if (IS_ENABLED(CONFIG_RELOCATABLE_RAMSTAGE))
|
|
return;
|
|
|
|
newgdt = cbmem_find(CBMEM_ID_GDT);
|
|
num_gdt_bytes = (uintptr_t)&gdt_end - (uintptr_t)&gdt;
|
|
if (!newgdt) {
|
|
newgdt = cbmem_add(CBMEM_ID_GDT, ALIGN(num_gdt_bytes, 512));
|
|
if (!newgdt) {
|
|
printk(BIOS_ERR, "Error: Could not relocate GDT.\n");
|
|
return;
|
|
}
|
|
memcpy((void *)newgdt, &gdt, num_gdt_bytes);
|
|
}
|
|
printk(BIOS_DEBUG, "Moving GDT to %p...", newgdt);
|
|
|
|
gdtarg.base = (uintptr_t)newgdt;
|
|
gdtarg.limit = num_gdt_bytes - 1;
|
|
|
|
__asm__ __volatile__ ("lgdt %0\n\t" : : "m" (gdtarg));
|
|
printk(BIOS_DEBUG, "ok\n");
|
|
}
|
|
RAMSTAGE_CBMEM_INIT_HOOK(move_gdt)
|