iceflower/speed-dreams-code
1
0
Fork 0
forked from speed-dreams/speed-dreams-code
Code Pull requests Activity

Re #787 MSVC warning level raised to 4 (was 3) => make it closer to our current GCC warning set + hidden C4251 everywhere

Browse source 
git-svn-id: https://svn.code.sf.net/p/speed-dreams/code/trunk@5171 30fe4595-0a0c-4342-8851-515496e4dcbd

Former-commit-id: 3271e371f9560848bd202575f8046f3eef60233e
Former-commit-id: d30e19db7138e00925b42e7466360d3146a4eef8
This commit is contained in:
pouillot 2013-02-22 18:02:47 +00:00
parent ea9a7a64d4
commit 777a820089
2 changed files with 31 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
cmake/options.cmake
View file

@ -111,9 +111,6 @@ MACRO(ADD_SD_COMPILE_OPTIONS)
IF(MSVC)
# Suppress bothering MSVC warnings
ADD_DEFINITIONS(-D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS)
# Inhibit definition of Macros min(a,b) and max(a,b) for Windows MSVC builds,
# as the names conflict with the template functions from standard template library
ADD_DEFINITIONS(-DNOMINMAX)
@ -178,9 +175,37 @@ MACRO(ADD_SD_COMPILE_OPTIONS)
# GCC warnings (at least for the 4.x series, there are none by default).
IF(CMAKE_COMPILER_IS_GNUCXX)
SET(_SD_WARN_OPTS "-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers")
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${_SD_WARN_OPTS}")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${_SD_WARN_OPTS}")
# Add useful warnings / checks.
SET(_SD_WOPTS "-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers")
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${_SD_WOPTS}")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${_SD_WOPTS}")
# MSVC warnings (default warning level 3 is not exactly what we want).
ELSEIF(MSVC)
# Suppress bothering MSVC warnings and add useful warnings / checks.
SET(_SD_WOPTS "/W4") # Better warning level (default seems to be 3).
# Level 3 useless/boring warnings.
SET(_SD_WOPTS "${_SD_WOPTS} /wd4251") # class XXX needs a DLL interface
SET(_SD_WOPTS "${_SD_WOPTS} /wd4996") # std::_Copy_opt disaproved because unsafe
# Level 4 useless/boring warnings.
SET(_SD_WOPTS "${_SD_WOPTS} /wd4100") # unreferenced formal parameter
SET(_SD_WOPTS "${_SD_WOPTS} /wd4127") # conditional expression is constant
SET(_SD_WOPTS "${_SD_WOPTS} /wd4201") # nonstandard extension used : nameless struct/union
SET(_SD_WOPTS "${_SD_WOPTS} /wd4706") # assignment within conditional expression
# Other useless warnings.
ADD_DEFINITIONS(-D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS)
# That's all.
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${_SD_WOPTS}")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${_SD_WOPTS}")
ENDIF(CMAKE_COMPILER_IS_GNUCXX)
ENDIF(NOT _ALREADY_DONE)

4
src/libs/tgf/windowsspec.cpp
View file

@ -31,10 +31,6 @@
#include "tgf.h"
#include "os.h"
#ifdef _MSC_VER
#pragma warning(disable:4996) // std::_Copy_opt was declared as disaproved because unsafe
#endif // _MSC_VER
/*
* Function
* windowsModLoad