Small cleanup

This commit is contained in:
Adrien Bourmault 2019-11-08 14:39:20 +01:00
parent 1427b8ac01
commit b6aa941715
5 changed files with 5 additions and 10 deletions

View File

@ -98,9 +98,6 @@ write:
mov qword [VGA_X], 0
pop rax
jmp .pLoop
.scroll:
; XXX I don't think I'll implement this, but never know...;
jmp .pLoop
dump:
;-----------------------------------------------------------------------;

View File

@ -124,7 +124,6 @@ CheckA20:
; ;
; Not a function because it wipes the stack ;) ;
; ---------------------------------------------------------------------------- ;
; XXX : MAKE A PAGE GUARD FOR THE STACK
InitStack:
xor rax, rax ; "Fill pattern"
push rcx
@ -166,4 +165,4 @@ InitStack:
pop rdi
pop rcx
jmp AfterInitStack
jmp AfterInitStack

View File

@ -56,8 +56,8 @@ Bootdrv db 0
IoReadATA:
;-----------------------------------------------------------------------;
; x64/LM ATA Reading function ;
; rsi : number of sectors to read XXX ;
; rdx : the first sector to read ;
; rsi : number of sectors to read XXX seems to be buggy ;
; rdx : the first sector to read ;
;-----------------------------------------------------------------------;
; Technical infos about the ports (Intel Doc):
@ -136,4 +136,4 @@ still_going:
mov dx, 0x1f0 ; Data port - data comes in and out of here.
rep insw
pop rbx
ret
ret

View File

@ -110,7 +110,7 @@ settingUp:
//
void KeSetupIDT(void)
{
// XXX detect the APIC with cpuid !
// XXX detect the APIC with cpuid and, perhaps, use it !
EnablePIC();
ushort codeSeg = (ushort)(ulong)BtLoaderInfo.codeSegment;

View File

@ -333,7 +333,6 @@ error_t vbprintf(Buffer_t *buf, const char *fmt, va_list ap)
// We use s to iterate convbuf
s = convbuf;
// FIXME: this works, but is ugly as hell
#define bdoconvrt(pref, type, vtype) \
do { \
type i_##type = (type)va_arg(ap, vtype); \