speed-dreams/speed-dreams-code
6
0
Fork 1
Code Issues 8 Pull requests 1 Projects Releases Packages Wiki Activity Actions

filesetup.cpp: Ensure destination dir before copy

Browse source 
When GfFileSetup is called on a fresh installation, none of the
destination directories might exist.

On the other hand, robustness has been slightly improved by adding calls
to good() and is_open().
This commit is contained in:
Xavier Del Campo Romero 2025-01-01 21:54:29 +01:00
parent 1f81d42305
commit 7e72f12a48
Signed by: xavi
GPG key ID: 84FF3612A9BF43F2
1 changed files with 37 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
src/libs/tgf/filesetup.cpp
View file

@ -55,24 +55,51 @@ static bool needs_update(const struct version &src, const struct version &dst)
static int update(const std::string &file)
{
const char *datadir = GfDataDir(), *localdir = GfLocalDir();
int ret = -1;
char *dstdir = nullptr;
std::string srcpath = std::string(GfDataDir()) + file,
dstpath = std::string(GfLocalDir()) + file;
const char *sp = srcpath.c_str(), *dp = dstpath.c_str();
std::ifstream src(srcpath, std::ios::binary);
std::ofstream dst;
if (!datadir)
if (!src.is_open())
{
GfLogError("GfDataDir failed\n");
return -1;
GfLogError("Failed to open file for reading: %s\n", sp);
goto end;
}
else if (!localdir)
else if (!(dstdir = GfFileGetDirName(dp)))
{
GfLogError("GfLocalDir failed\n");
return -1;
GfLogError("GfFileGetDirName %s failed\n", dp);
goto end;
}
else if (GfDirCreate(dstdir) != GF_DIR_CREATED)
{
GfLogError("Failed to created directory: %s\n", dstdir);
goto end;
}
std::ifstream src(std::string(datadir) + file, std::ios::binary);
std::ofstream dst(std::string(localdir) + file, std::ios::binary);
dst.open(dstpath, std::ios::binary);
if (!dst.is_open())
{
GfLogError("Failed to open file for writing: %s\n", dp);
goto end;
}
dst << src.rdbuf();
return 0;
if (!dst.good())
{
GfLogError("Failed to write from %s to %s\n", sp, dp);
goto end;
}
ret = 0;
end:
free(dstdir);
return ret;
}
static int process(const std::string &file)