2011-02-22 15:35:05 +01:00
##
## This file is part of the coreboot project.
##
## Copyright (C) 2011 secunet Security Networks AG
##
## This program is free software; you can redistribute it and/or modify
## it under the terms of the GNU General Public License as published by
## the Free Software Foundation; version 2 of the License.
##
## This program is distributed in the hope that it will be useful,
## but WITHOUT ANY WARRANTY; without even the implied warranty of
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
## GNU General Public License for more details.
##
## You should have received a copy of the GNU General Public License
## along with this program; if not, write to the Free Software
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
##
#######################################################################
# misleadingly named, this is the coreboot version
2012-12-11 00:47:23 +01:00
export KERNELVERSION := $ ( shell if [ - d " $ (top)/.git " - a - f " `which git` " ]; \
then git describe -- dirty -- always || git describe ; \
else echo 4.0 $ ( KERNELREVISION ); fi )
2011-02-22 15:35:05 +01:00
2013-12-29 18:45:23 +01:00
#######################################################################
# Test for coreboot toolchain (except when explicitely not requested)
ifneq ( $ ( NOCOMPILE ), 1 )
# only run if we're doing a build (not for tests, kconfig, ...)
ifneq ( $ ( CONFIG_ANY_TOOLCHAIN ), y )
_toolchain = $ ( shell $ ( CC_i386 ) - v 2 >& 1 | grep - q " gcc version .*coreboot toolchain " && echo coreboot )
ifneq ( $ ( _toolchain ), coreboot )
$ ( error Please use the coreboot toolchain ( or prove that your toolchain works ))
endif
endif
endif
2011-02-22 15:35:05 +01:00
#######################################################################
# Basic component discovery
MAINBOARDDIR = $ ( call strip_quotes , $ ( CONFIG_MAINBOARD_DIR ))
export MAINBOARDDIR
2012-04-19 11:00:06 +02:00
## Final build results, which CBFSTOOL uses to create the final
## rom image file, are placed under $(objcbfs).
## These typically have suffixes .debug .elf .bin and .map
2012-08-09 20:09:44 +02:00
export objcbfs := $ ( obj ) / cbfs / $ ( call strip_quotes , $ ( CONFIG_CBFS_PREFIX ))
2012-04-19 11:00:06 +02:00
## Based on the active configuration, Makefile conditionally collects
## the required assembly includes and saves them in a file.
## Such files that do not have a clear one-to-one relation to a source
## file under src/ are placed and built under $(objgenerated)
export objgenerated := $ ( obj ) / generated
2011-02-22 15:35:05 +01:00
#######################################################################
# root rule to resolve if in build mode (ie. configuration exists)
real - target : $ ( obj ) / config . h coreboot
2012-04-19 11:00:06 +02:00
coreboot : build - dirs $ ( obj ) / coreboot . rom
2011-02-22 15:35:05 +01:00
#######################################################################
# our phony targets
2012-04-19 11:00:06 +02:00
PHONY += clean - abuild coreboot lint lint - stable build - dirs
2011-02-22 15:35:05 +01:00
#######################################################################
# root source directories of coreboot
2013-09-07 07:41:48 +02:00
subdirs - y := src / lib src / console src / device src / ec src / southbridge src / soc
2011-12-01 16:49:43 +01:00
subdirs - y += src / northbridge src / superio src / drivers src / cpu src / vendorcode
2012-03-09 10:53:52 +01:00
subdirs - y += util / cbfstool util / sconfig util / nvramtool
2011-02-22 15:35:05 +01:00
subdirs - y += src / arch / $ ( ARCHDIR - y )
subdirs - y += src / mainboard / $ ( MAINBOARDDIR )
2011-09-02 09:57:01 +02:00
subdirs - y += site - local
2011-02-22 15:35:05 +01:00
#######################################################################
# Add source classes and their build options
2013-01-12 07:41:44 +01:00
classes - y := ramstage romstage bootblock smm smmstub cpu_microcode rmodules
2011-02-22 15:35:05 +01:00
2012-11-25 17:10:47 +01:00
#######################################################################
# Helper functions for ramstage postprocess
spc :=
spc +=
$ ( spc ) :=
$ ( spc ) +=
# files-in-dir-recursive,dir,files
files - in - dir - recursive = $ ( filter $ ( 1 ) % , $ ( 2 ))
# parent-dir,dir/
parent - dir = $ ( dir $ ( subst $ ( ), / , $ ( strip $ ( subst / , , $ ( 1 )))))
# filters out exactly the directory specified
# filter-out-dir,dir_to_keep,dirs
filter - out - dir = $ ( filter - out $ ( 1 ), $ ( 2 ))
# filters out dir_to_keep and all its parents
# filter-out-dirs,dir_to_keep,dirs
filter - out - dirs = $ ( if $ ( filter - out ./ , $ ( 1 )), $ ( call filter - out - dirs , $ ( call parent - dir , $ ( 1 )), $ ( call filter - out - dir , $ ( 1 ), $ ( 2 ))), $ ( call filter - out - dir , $ ( 1 ), $ ( 2 )))
# dir-wildcards,dirs
dir - wildcards = $ ( addsuffix % , $ ( 1 ))
# files-in-dir,dir,files
files - in - dir = $ ( filter - out $ ( call dir - wildcards , $ ( call filter - out - dirs , $ ( 1 ), $ ( dir $ ( 2 )))), $ ( call files - in - dir - recursive , $ ( 1 ), $ ( 2 )))
#######################################################################
# reduce command line length by linking the objects of each
# directory into an intermediate file
ramstage - postprocess = $ ( foreach d , $ ( sort $ ( dir $ ( 1 ))), \
$ ( eval $ ( d ) ramstage . o : $ ( call files - in - dir , $ ( d ), $ ( 1 )); $ $ ( LD ) - o $ $ @ - r $ $ ^ ) \
$ ( eval ramstage - objs := $ ( d ) ramstage . o $ ( filter - out $ ( call files - in - dir , $ ( d ), $ ( 1 )), $ ( ramstage - objs ))))
2011-02-22 15:35:05 +01:00
romstage - c - ccopts :=- D__PRE_RAM__
2011-04-10 06:15:23 +02:00
romstage - S - ccopts :=- D__PRE_RAM__
2011-09-02 23:23:41 +02:00
ifeq ( $ ( CONFIG_TRACE ), y )
ramstage - c - ccopts := - finstrument - functions
endif
Implement GCC code coverage analysis
In order to provide some insight on what code is executed during
coreboot's run time and how well our test scenarios work, this
adds code coverage support to coreboot's ram stage. This should
be easily adaptable for payloads, and maybe even romstage.
See http://gcc.gnu.org/onlinedocs/gcc/Gcov.html for
more information.
To instrument coreboot, select CONFIG_COVERAGE ("Code coverage
support") in Kconfig, and recompile coreboot. coreboot will then
store its code coverage information into CBMEM, if possible.
Then, run "cbmem -CV" as root on the target system running the
instrumented coreboot binary. This will create a whole bunch of
.gcda files that contain coverage information. Tar them up, copy
them to your build system machine, and untar them. Then you can
use your favorite coverage utility (gcov, lcov, ...) to visualize
code coverage.
For a sneak peak of what will expect you, please take a look
at http://www.coreboot.org/~stepan/coreboot-coverage/
Change-Id: Ib287d8309878a1f5c4be770c38b1bc0bb3aa6ec7
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/2052
Tested-by: build bot (Jenkins)
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: Martin Roth <martin@se-eng.com>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
2012-12-19 01:23:28 +01:00
ifeq ( $ ( CONFIG_COVERAGE ), y )
ramstage - c - ccopts +=- fprofile - arcs - ftest - coverage
endif
2011-09-02 23:23:41 +02:00
2012-04-30 21:06:10 +02:00
ifeq ( $ ( CONFIG_USE_BLOBS ), y )
forgetthis := $ ( shell git submodule update -- init -- checkout 3 rdparty )
endif
2013-02-04 07:38:03 +01:00
bootblock - c - ccopts :=- D__BOOT_BLOCK__ - D__PRE_RAM__
bootblock - S - ccopts :=- D__BOOT_BLOCK__ - D__PRE_RAM__
2013-01-31 18:09:24 +01:00
2013-01-04 00:38:47 +01:00
smmstub - c - ccopts :=- D__SMM__
smmstub - S - ccopts :=- D__SMM__
2011-04-15 00:28:00 +02:00
smm - c - ccopts :=- D__SMM__
smm - S - ccopts :=- D__SMM__
2011-02-22 15:35:05 +01:00
2012-04-02 22:24:04 +02:00
# SMM TSEG base is dynamic
2013-01-04 00:38:47 +01:00
ifneq ( $ ( CONFIG_SMM_MODULES ), y )
2012-04-02 22:24:04 +02:00
ifeq ( $ ( CONFIG_SMM_TSEG ), y )
smm - c - ccopts += - fpic
endif
2013-01-04 00:38:47 +01:00
endif
2012-04-02 22:24:04 +02:00
2011-03-08 21:49:18 +01:00
ramstage - c - deps := $ $ ( OPTION_TABLE_H )
romstage - c - deps := $ $ ( OPTION_TABLE_H )
2013-01-31 18:09:24 +01:00
bootblock - c - deps := $ $ ( OPTION_TABLE_H )
2013-11-30 20:06:18 +01:00
smm - c - deps := $ $ ( OPTION_TABLE_H )
2011-03-08 21:49:18 +01:00
2011-02-22 15:35:05 +01:00
#######################################################################
# Add handler to compile ACPI's ASL
define ramstage - objs_asl_template
2011-03-29 11:01:10 +02:00
$ ( obj ) / $ ( 1 ) . ramstage . o : src / $ ( 1 ) . asl $ ( obj ) / config . h
2011-02-22 15:35:05 +01:00
@ printf " IASL $ $ (subst $ (top)/,, $ $ (@)) \n "
2012-05-05 15:11:22 +02:00
$ ( CC ) - x assembler - with - cpp - E - MMD - MT $ $ ( @ ) - D__ACPI__ - P - include $ ( src ) / include / kconfig . h - I $ ( obj ) - I $ ( src ) - I $ ( src ) / include - I $ ( src ) / arch / $ ( ARCHDIR - y ) / include - I $ ( src ) / mainboard / $ ( MAINBOARDDIR ) $ $ < - o $ $ ( basename $ $ @ ) . asl
2011-08-09 00:07:50 +02:00
cd $ $ ( dir $ $ @ ); $ ( IASL ) - p $ $ ( notdir $ $ @ ) - tc $ $ ( notdir $ $ ( basename $ $ @ )) . asl
2011-06-01 21:54:16 +02:00
mv $ $ ( basename $ $ @ ) . hex $ $ ( basename $ $ @ ) . c
2011-02-22 15:35:05 +01:00
$ ( CC ) $ $ ( CFLAGS ) $ $ ( if $ $ ( subst dsdt ,, $ $ ( basename $ $ ( notdir $ ( 1 )))), - DAmlCode = AmlCode_ $ $ ( basename $ $ ( notdir $ ( 1 )))) - c - o $ $ @ $ $ ( basename $ $ @ ) . c
# keep %.o: %.c rule from catching the temporary .c file after a make clean
mv $ $ ( basename $ $ @ ) . c $ $ ( basename $ $ @ ) . hex
endef
2012-03-09 12:30:07 +01:00
#######################################################################
# Parse plaintext cmos defaults into binary format
# arg1: source file
# arg2: binary file name
cbfs - files - processor - nvramtool = \
$ ( eval $ ( 2 ) : $ ( 1 ) $ ( src ) / mainboard / $ ( MAINBOARDDIR ) / cmos . layout | $ ( objutil ) / nvramtool / nvramtool ; \
printf " CREATE $ (2) (from $ (1)) \n " ; $ ( objutil ) / nvramtool / nvramtool - y $ ( src ) / mainboard / $ ( MAINBOARDDIR ) / cmos . layout - D $ ( 2 ) . tmp - p $ ( 1 ) && mv $ ( 2 ) . tmp $ ( 2 ))
2012-04-30 23:15:17 +02:00
#######################################################################
# Link VSA binary to ELF-ish stage
# arg1: source file
# arg2: binary file name
cbfs - files - processor - vsa = \
$ ( eval $ ( 2 ) : $ ( 1 ) ; \
printf " CREATE $ (2) (from $ (1)) \n " ; $ ( OBJCOPY ) -- set - start 0x20 -- adjust - vma 0x60000 - I binary - O elf32 - i386 - B i386 $ ( 1 ) $ ( 2 ) . tmp && $ ( LD ) - m elf_i386 - e 0x60020 -- section - start . data = 0x60000 $ ( 2 ) . tmp - o $ ( 2 ))
2011-02-22 15:35:05 +01:00
#######################################################################
# Add handler for arbitrary files in CBFS
$ ( call add - special - class , cbfs - files )
cbfs - files - handler = \
2012-03-09 12:30:07 +01:00
$ ( eval tmp - cbfs - method := $ ( word 2 , $ ( subst : , , $ ( $ ( 2 ) - file )))) \
2012-11-15 14:51:54 +01:00
$ ( eval $ ( 2 ) - file := $ ( call strip_quotes , $ ( word 1 , $ ( subst : , , $ ( $ ( 2 ) - file ))))) \
2011-02-22 15:35:05 +01:00
$ ( if $ ( wildcard $ ( 1 ) $ ( $ ( 2 ) - file )), \
$ ( eval tmp - cbfs - file := $ ( wildcard $ ( 1 ) $ ( $ ( 2 ) - file ))), \
$ ( eval tmp - cbfs - file := $ ( $ ( 2 ) - file ))) \
2013-02-16 01:06:57 +01:00
$ ( if $ ( strip $ ( $ ( 2 ) - required )), \
$ ( if $ ( wildcard $ ( tmp - cbfs - file )),, \
$ ( info This build configuration requires $ ( $ ( 2 ) - required )) \
$ ( eval FAILBUILD := 1 ) \
)) \
2012-03-09 12:30:07 +01:00
$ ( if $ ( tmp - cbfs - method ), \
$ ( eval tmp - old - cbfs - file := $ ( tmp - cbfs - file )) \
2012-09-21 18:11:59 +02:00
$ ( eval tmp - cbfs - file := $ ( shell mkdir - p $ ( obj ) / mainboard / $ ( MAINBOARDDIR ); mktemp $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / cbfs - file . XXXXXX ) . out ) \
2012-03-09 12:30:07 +01:00
$ ( call cbfs - files - processor - $ ( tmp - cbfs - method ), $ ( tmp - old - cbfs - file ), $ ( tmp - cbfs - file ))) \
2012-08-14 19:01:53 +02:00
$ ( eval cbfs - files += $ ( tmp - cbfs - file ) | $ ( 2 ) | $ ( $ ( 2 ) - type ) | $ ( $ ( 2 ) - compression ) | $ ( $ ( 2 ) - position )) \
2011-02-22 15:35:05 +01:00
$ ( eval $ ( 2 ) - name := ) \
$ ( eval $ ( 2 ) - type := ) \
2012-08-14 19:01:53 +02:00
$ ( eval $ ( 2 ) - compression := ) \
2013-02-16 01:06:57 +01:00
$ ( eval $ ( 2 ) - position := ) \
$ ( eval $ ( 2 ) - required := )
2011-02-22 15:35:05 +01:00
#######################################################################
# a variety of flags for our build
2012-10-30 00:52:36 +01:00
CBFS_COMPRESS_FLAG := none
2011-05-02 21:53:04 +02:00
ifeq ( $ ( CONFIG_COMPRESS_RAMSTAGE ), y )
2012-10-30 00:52:36 +01:00
CBFS_COMPRESS_FLAG := LZMA
2011-05-02 21:53:04 +02:00
endif
2012-10-30 00:52:36 +01:00
CBFS_PAYLOAD_COMPRESS_FLAG := none
2011-02-22 15:35:05 +01:00
ifeq ( $ ( CONFIG_COMPRESSED_PAYLOAD_LZMA ), y )
2012-10-30 00:52:36 +01:00
CBFS_PAYLOAD_COMPRESS_FLAG := LZMA
2011-02-22 15:35:05 +01:00
endif
ifneq ( $ ( CONFIG_LOCALVERSION ), " " )
COREBOOT_EXTRA_VERSION := - $ ( call strip_quotes , $ ( CONFIG_LOCALVERSION ))
endif
INCLUDES := - Isrc - Isrc / include - I $ ( obj ) - Isrc / arch / $ ( ARCHDIR - y ) / include
2012-11-30 21:34:04 +01:00
INCLUDES += - Isrc / device / oprom / include
2011-02-22 15:35:05 +01:00
# abspath is a workaround for romcc
2012-05-05 15:11:22 +02:00
INCLUDES += - include $ ( src ) / include / kconfig . h
2011-02-22 15:35:05 +01:00
2011-05-05 18:45:36 +02:00
CFLAGS = $ ( INCLUDES ) - Os - pipe - g - nostdinc
2011-02-22 15:35:05 +01:00
CFLAGS += - nostdlib - Wall - Wundef - Wstrict - prototypes - Wmissing - prototypes
CFLAGS += - Wwrite - strings - Wredundant - decls - Wno - trigraphs
CFLAGS += - Wstrict - aliasing - Wshadow
ifeq ( $ ( CONFIG_WARNINGS_ARE_ERRORS ), y )
CFLAGS += - Werror
endif
CFLAGS += - fno - common - ffreestanding - fno - builtin - fomit - frame - pointer
2013-06-19 16:16:05 +02:00
additional - dirs := $ ( objutil ) / cbfstool $ ( objutil ) / romcc $ ( objutil ) / ifdtool \
$ ( objutil ) / ifdfake $ ( objutil ) / options
2011-02-22 15:35:05 +01:00
#######################################################################
# generate build support files
$ ( obj ) / build . h : . xcompile
@ printf " GEN build.h \n "
rm - f $ ( obj ) / build . h
printf " /* build system definitions (autogenerated) */ \n " > $ ( obj ) / build . ht
printf " #ifndef __BUILD_H \n " >> $ ( obj ) / build . ht
printf " #define __BUILD_H \n \n " >> $ ( obj ) / build . ht
2011-03-17 08:47:49 +01:00
printf " #define COREBOOT_VERSION \" $ (KERNELVERSION) \" \n " >> $ ( obj ) / build . ht
2011-02-22 15:35:05 +01:00
printf " #define COREBOOT_EXTRA_VERSION \" $ (COREBOOT_EXTRA_VERSION) \" \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_BUILD \" `LANG= date` \" \n " >> $ ( obj ) / build . ht
2012-11-09 12:55:04 +01:00
printf " #define COREBOOT_BUILD_YEAR_BCD 0x`LANG= date + " % y " ` \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_BUILD_MONTH_BCD 0x`LANG= date + " % m " ` \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_BUILD_DAY_BCD 0x`LANG= date + " % d " ` \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_BUILD_WEEKDAY_BCD 0x`LANG= date + " % w " ` \n " >> $ ( obj ) / build . ht
2011-08-14 20:56:34 +02:00
printf " #define COREBOOT_DMI_DATE \" `LANG= date + " % m /% d /% Y " ` \" \n " >> $ ( obj ) / build . ht
2011-02-22 15:35:05 +01:00
printf " \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_COMPILER \" $ (shell LANG= $ (CC) --version | head -n1) \" \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_ASSEMBLER \" $ (shell LANG= $ (AS) --version | head -n1) \" \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_LINKER \" $ (shell LANG= $ (LD) --version | head -n1) \" \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_COMPILE_TIME \" `LANG= date +%T` \" \n " >> $ ( obj ) / build . ht
printf " #define COREBOOT_COMPILE_BY \" $ (subst \ ,@, $ (shell PATH= $ $PATH :/usr/ucb whoami)) \" \n " >> $ ( obj ) / build . ht
2012-09-28 10:06:44 +02:00
printf " #define COREBOOT_COMPILE_HOST \" $ (shell hostname -s 2>/dev/null || hostname 2>/dev/null) \" \n " >> $ ( obj ) / build . ht
2011-02-22 15:35:05 +01:00
printf " #define COREBOOT_COMPILE_DOMAIN \" $ (shell test `uname -s` = " Linux " && dnsdomainname || domainname 2>/dev/null) \" \n " >> $ ( obj ) / build . ht
printf " #endif \n " >> $ ( obj ) / build . ht
mv $ ( obj ) / build . ht $ ( obj ) / build . h
$ ( obj ) / ldoptions : $ ( obj ) / config . h
awk '/^#define ([^"])* ([^"])*$$/ {gsub("\\r","",$$3); print $$2 " = " $$3 ";";}' $ < > $ @
2012-04-19 11:00:06 +02:00
build - dirs :
mkdir - p $ ( objcbfs ) $ ( objgenerated )
2011-02-22 15:35:05 +01:00
#######################################################################
# Build the tools
CBFSTOOL := $ ( obj ) / cbfstool
2014-03-10 22:13:58 +01:00
RMODTOOL := $ ( obj ) / rmodtool
2011-02-22 15:35:05 +01:00
$ ( CBFSTOOL ) : $ ( objutil ) / cbfstool / cbfstool
cp $ < $ @
2014-03-10 22:13:58 +01:00
$ ( RMODTOOL ) : $ ( objutil ) / cbfstool / rmodtool
cp $ < $ @
2011-02-22 15:35:05 +01:00
_WINCHECK = $ ( shell uname - o 2 > / dev / null )
STACK =
ifeq ( $ ( _WINCHECK ), Msys )
STACK =- Wl , -- stack , 16384000
endif
ifeq ( $ ( _WINCHECK ), Cygwin )
STACK =- Wl , -- stack , 16384000
endif
ROMCC := $ ( objutil ) / romcc / romcc
$ ( ROMCC ) : $ ( top ) / util / romcc / romcc . c
@ printf " HOSTCC $ (subst $ (obj)/,, $ (@)) (this may take a while) \n "
@ # Note: Adding -O2 here might cause problems. For details see:
@ # http://www.coreboot.org/pipermail/coreboot/2010-February/055825.html
$ ( HOSTCC ) - g $ ( STACK ) - Wall - o $ @ $ <
2012-08-16 23:05:42 +02:00
IFDTOOL := $ ( objutil ) / ifdtool / ifdtool
$ ( IFDTOOL ) : $ ( top ) / util / ifdtool / ifdtool . c
@ printf " HOSTCC $ (subst $ (obj)/,, $ (@)) \n "
$ ( HOSTCC ) $ ( HOSTCFLAGS ) - o $ @ $ <
2013-06-19 16:16:05 +02:00
IFDFAKE := $ ( objutil ) / ifdfake / ifdfake
$ ( IFDFAKE ) : $ ( top ) / util / ifdfake / ifdfake . c
@ printf " HOSTCC $ (subst $ (obj)/,, $ (@)) \n "
$ ( HOSTCC ) $ ( HOSTCFLAGS ) - o $ @ $ <
2011-02-22 15:35:05 +01:00
#######################################################################
# needed objects that every mainboard uses
# Creation of these is architecture and mainboard independent
$ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / static . c : $ ( src ) / mainboard / $ ( MAINBOARDDIR ) / devicetree . cb $ ( objutil ) / sconfig / sconfig
@ printf " SCONFIG $ (subst $ (src)/,, $ (<)) \n "
mkdir - p $ ( obj ) / mainboard / $ ( MAINBOARDDIR )
$ ( objutil ) / sconfig / sconfig $ ( MAINBOARDDIR ) $ ( obj ) / mainboard / $ ( MAINBOARDDIR )
ramstage - y += $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / static . c
Make the device tree available in the rom stage
We thought about two ways to do this change. The way we decided to try
was to
1. drop all ops from devices in romstage
2. constify all devices in romstage (make them read-only) so we can
compile static.c into romstage
3. the device tree "devices" can be used to read configuration from
the device tree (and nothing else, really)
4. the device tree devices are accessed through struct device * in
romstage only. device_t stays the typedef to int in romstage
5. Use the same static.c file in ramstage and romstage
We declare structs as follows:
ROMSTAGE_CONST struct bus dev_root_links[];
ROMSTAGE_CONST is const in romstage and empty in ramstage; This
forces all of the device tree into the text area.
So a struct looks like this:
static ROMSTAGE_CONST struct device _dev21 = {
#ifndef __PRE_RAM__
.ops = 0,
#endif
.bus = &_dev7_links[0],
.path = {.type=DEVICE_PATH_PCI,{.pci={ .devfn = PCI_DEVFN(0x1c,3)}}},
.enabled = 0,
.on_mainboard = 1,
.subsystem_vendor = 0x1ae0,
.subsystem_device = 0xc000,
.link_list = NULL,
.sibling = &_dev22,
#ifndef __PRE_RAM__
.chip_ops = &southbridge_intel_bd82x6x_ops,
#endif
.chip_info = &southbridge_intel_bd82x6x_info_10,
.next=&_dev22
};
Change-Id: I722454d8d3c40baf7df989f5a6891f6ba7db5727
Signed-off-by: Ronald G. Minnich <rminnich@chromium.org>
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/1398
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
2012-08-01 01:47:25 +02:00
romstage - y += $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / static . c
2011-02-22 15:35:05 +01:00
$ ( objutil ) /%. o : $ ( objutil ) /%. c
@ printf " HOSTCC $ (subst $ (objutil)/,, $ (@)) \n "
$ ( HOSTCC ) - MMD - I $ ( subst $ ( objutil ) / , util / , $ ( dir $ < )) - I $ ( dir $ < ) $ ( HOSTCFLAGS ) - c - o $ @ $ <
2011-05-21 01:08:12 +02:00
$ ( obj ) /%. ramstage . o $ ( abspath $ ( obj )) /%. ramstage . o : $ ( obj ) /%. c $ ( obj ) / config . h $ ( OPTION_TABLE_H )
2011-02-22 15:35:05 +01:00
@ printf " CC $ (subst $ (obj)/,, $ (@)) \n "
$ ( CC ) - MMD $ ( CFLAGS ) - c - o $ @ $ <
Make the device tree available in the rom stage
We thought about two ways to do this change. The way we decided to try
was to
1. drop all ops from devices in romstage
2. constify all devices in romstage (make them read-only) so we can
compile static.c into romstage
3. the device tree "devices" can be used to read configuration from
the device tree (and nothing else, really)
4. the device tree devices are accessed through struct device * in
romstage only. device_t stays the typedef to int in romstage
5. Use the same static.c file in ramstage and romstage
We declare structs as follows:
ROMSTAGE_CONST struct bus dev_root_links[];
ROMSTAGE_CONST is const in romstage and empty in ramstage; This
forces all of the device tree into the text area.
So a struct looks like this:
static ROMSTAGE_CONST struct device _dev21 = {
#ifndef __PRE_RAM__
.ops = 0,
#endif
.bus = &_dev7_links[0],
.path = {.type=DEVICE_PATH_PCI,{.pci={ .devfn = PCI_DEVFN(0x1c,3)}}},
.enabled = 0,
.on_mainboard = 1,
.subsystem_vendor = 0x1ae0,
.subsystem_device = 0xc000,
.link_list = NULL,
.sibling = &_dev22,
#ifndef __PRE_RAM__
.chip_ops = &southbridge_intel_bd82x6x_ops,
#endif
.chip_info = &southbridge_intel_bd82x6x_info_10,
.next=&_dev22
};
Change-Id: I722454d8d3c40baf7df989f5a6891f6ba7db5727
Signed-off-by: Ronald G. Minnich <rminnich@chromium.org>
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/1398
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
2012-08-01 01:47:25 +02:00
$ ( obj ) /%. romstage . o $ ( abspath $ ( obj )) /%. romstage . o : $ ( obj ) /%. c $ ( obj ) / config . h $ ( OPTION_TABLE_H )
@ printf " CC $ (subst $ (obj)/,, $ (@)) \n "
$ ( CC ) - MMD - D__PRE_RAM__ $ ( CFLAGS ) - c - o $ @ $ <
2013-01-31 18:09:24 +01:00
$ ( obj ) /%. bootblock . o $ ( abspath $ ( obj )) /%. bootblock . o : $ ( obj ) /%. c $ ( obj ) / config . h $ ( OPTION_TABLE_H )
@ printf " CC $ (subst $ (obj)/,, $ (@)) \n "
2013-02-04 07:38:03 +01:00
$ ( CC ) - MMD $ ( bootblock - c - ccopts ) $ ( CFLAGS ) - c - o $ @ $ <
2013-01-31 18:09:24 +01:00
2011-02-22 15:35:05 +01:00
#######################################################################
# Clean up rules
clean - abuild :
rm - rf coreboot - builds
clean - for - update - target :
2014-04-22 19:41:05 +02:00
rm - f $ ( obj ) / ramstage * $ ( obj ) / coreboot . romstage $ ( obj ) / coreboot . pre * $ ( obj ) / coreboot . bootblock $ ( obj ) / coreboot . a
2011-02-22 15:35:05 +01:00
rm - rf $ ( obj ) / bootblock * $ ( obj ) / romstage * $ ( obj ) / location .*
rm - f $ ( obj ) / option_table .* $ ( obj ) / crt0 . S $ ( obj ) / ldscript
rm - f $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / static . c $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / config . py $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / static . dot
rm - f $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / crt0 . s $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / crt0 . disasm
rm - f $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / romstage . inc
rm - f $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / bootblock .* $ ( obj ) / mainboard / $ ( MAINBOARDDIR ) / dsdt .*
rm - f $ ( obj ) / cpu / x86 / smm / smm_bin . c $ ( obj ) / cpu / x86 / smm / smm .* $ ( obj ) / cpu / x86 / smm / smm
2012-03-20 00:32:33 +01:00
$ ( MAKE ) - C payloads / external / SeaBIOS - f Makefile . inc clean OUT = $ ( abspath $ ( obj )) HOSTCC = " $ (HOSTCC) " CC = " $ (CC) " LD = " $ (LD) "
2011-02-22 15:35:05 +01:00
clean - target :
rm - f $ ( obj ) / coreboot *
#######################################################################
# Development utilities
printcrt0s :
@ echo crt0s = $ ( crt0s )
@ echo ldscripts = $ ( ldscripts )
update :
dongle . py - c / dev / term / 1 $ ( obj ) / coreboot . rom EOF
2012-02-25 19:42:59 +01:00
lint lint - stable :
2012-09-28 13:38:37 +02:00
FAILED = 0 ; LINTLOG = `mktemp .tmpconfig.lintXXXXX` ; \
2012-02-25 19:42:59 +01:00
for script in util / lint / $ @-* ; do \
2011-02-22 15:35:05 +01:00
echo ; echo `basename $$script` ; \
grep " ^# DESCR: " $$script | sed " s,.*DESCR: *,, " ; \
echo ======== ; \
$$script > $$LINTLOG ; \
2012-03-09 23:02:09 +01:00
if [ `cat $$LINTLOG | wc -l` - eq 0 ]; then \
2011-02-22 15:35:05 +01:00
printf " success \n \n " ; \
else \
echo test failed : ; \
cat $$LINTLOG ; \
rm - f $$LINTLOG ; \
FAILED = $ $ (( $$FAILED + 1 )); \
fi ; \
echo ======== ; \
done ; \
test $$FAILED - eq 0 || { echo " ERROR: $ $FAILED test(s) failed. " && exit 1 ; }; \
rm - f $$LINTLOG
2011-05-16 17:32:28 +02:00
2011-06-05 15:15:49 +02:00
gitconfig :
2012-10-22 10:29:37 +02:00
mkdir - p . git / hooks
2012-08-10 09:44:02 +02:00
for hook in commit - msg pre - commit ; do \
if [ util / gitconfig / $$hook - nt . git / hooks / $$hook - o \
! - x . git / hooks / $$hook ]; then \
cp util / gitconfig / $$hook . git / hooks / $$hook ; \
chmod + x . git / hooks / $$hook ; \
fi ; \
done
2013-01-03 17:26:09 +01:00
git config remote . origin . push HEAD : refs / for / master
2011-06-05 15:15:49 +02:00
( git config -- global user . name >/ dev / null && git config -- global user . email >/ dev / null ) || ( printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email@example.com\n' ; exit 1 )
2013-11-01 17:40:39 +01:00
crossgcc : crossgcc - i386 crossgcc - arm
2011-06-09 05:06:25 +02:00
2013-11-01 17:40:39 +01:00
. PHONY : crossgcc - i386 crossgcc - arm
crossgcc - i386 : clean - for - update
$ ( MAKE ) - C util / crossgcc build - i386 - without - gdb
crossgcc - arm : clean - for - update
$ ( MAKE ) - C util / crossgcc build - armv7a - without - gdb
crosstools : crosstools - i386
. PHONY : crosstools - i386 crosstools - arm
crosstools - i386 : clean - for - update
$ ( MAKE ) - C util / crossgcc build - i386
crosstools - arm : clean - for - update
$ ( MAKE ) - C util / crossgcc build - armv7a
2011-05-16 17:32:28 +02:00
crossgcc - clean : clean - for - update
$ ( MAKE ) - C util / crossgcc clean
2014-03-10 22:13:58 +01:00
tools : $ ( objutil ) / kconfig / conf $ ( objutil ) / cbfstool / cbfstool $ ( objutil ) / cbfstool / rmodtool $ ( objutil ) / nvramtool / nvramtool $ ( objutil ) / romcc / romcc $ ( objutil ) / sconfig / sconfig
2011-11-05 14:44:41 +01:00