GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

soc/intel/skylake: Drop unnecessary ignore_vtd option

Browse source 
It is zero for all mainboards. If one really wanted to ignore VT-d
support, a user-visible Kconfig option would be a better approach.

Change-Id: I320c10317f3fabee5443c16ebdf1ffd0e24193b8
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52101
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by:  Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Angel Pons 2021-04-05 12:03:08 +02:00 committed by Patrick Georgi
parent 3993d38ae6
commit 00f53a8d9e
6 changed files with 3 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/mainboard/protectli/vault_kbl/devicetree.cb
View file

@ -22,9 +22,6 @@ chip soc/intel/skylake
# Disable DPTF
register "dptf_enable" = "0"
# Enable VT-d
register "ignore_vtd" = "0"
# Enable SERIRQ continuous
register "serirq_mode" = "SERIRQ_CONTINUOUS"

3
src/soc/intel/skylake/acpi.c
View file

@ -460,11 +460,10 @@ unsigned long northbridge_write_acpi_tables(const struct device *const dev,
unsigned long current,
struct acpi_rsdp *const rsdp)
{
const struct soc_intel_skylake_config *const config = config_of(dev);
acpi_dmar_t *const dmar = (acpi_dmar_t *)current;
/* Create DMAR table only if we have VT-d capability. */
if (config->ignore_vtd || !soc_is_vtd_capable())
if (!soc_is_vtd_capable())
return current;
printk(BIOS_DEBUG, "ACPI: * DMAR\n");

2
src/soc/intel/skylake/chip.c
View file

@ -524,7 +524,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
params->PchIoApicBdfValid = 0;
/* Enable VT-d and X2APIC */
if (!config->ignore_vtd && soc_is_vtd_capable()) {
if (soc_is_vtd_capable()) {
params->VtdBaseAddress[0] = GFXVT_BASE_ADDRESS;
params->VtdBaseAddress[1] = VTVC0_BASE_ADDRESS;
params->X2ApicOptOut = 0;

3
src/soc/intel/skylake/chip.h
View file

@ -78,9 +78,6 @@ struct soc_intel_skylake_config {
/* TCC activation offset */
uint32_t tcc_offset;
/* Whether to ignore VT-d support of the SKU */
int ignore_vtd;
/*
* System Agent dynamic frequency configuration
* When enabled memory will be trained at two different frequencies.

5
src/soc/intel/skylake/romstage/systemagent.c
View file

@ -13,11 +13,6 @@
static void systemagent_vtd_init(void)
{
const struct device *const igd_dev = pcidev_path_on_root(SA_DEVFN_IGD);
const struct soc_intel_skylake_config *config = NULL;
config = config_of_soc();
if (config->ignore_vtd)
return;
const bool vtd_capable =
!(pci_read_config32(SA_DEV_ROOT, CAPID0_A) & VTD_DISABLE);

3
src/soc/intel/skylake/systemagent.c
View file

@ -39,12 +39,11 @@ void soc_add_fixed_mmio_resources(struct device *dev, int *index)
{ GDXCBAR, GDXC_BASE_ADDRESS, GDXC_BASE_SIZE, "GDXCBAR" },
{ EDRAMBAR, EDRAM_BASE_ADDRESS, EDRAM_BASE_SIZE, "EDRAMBAR" },
};
const struct soc_intel_skylake_config *const config = config_of(dev);
sa_add_fixed_mmio_resources(dev, index, soc_fixed_resources,
ARRAY_SIZE(soc_fixed_resources));
if (!config->ignore_vtd && soc_is_vtd_capable()) {
if (soc_is_vtd_capable()) {
if (igd_dev && igd_dev->enabled)
sa_add_fixed_mmio_resources(dev, index,
&soc_gfxvt_mmio_descriptor, 1);