soc/intel/alderlake: Lock PAM registers in finalize
Use the support from the previous patch to have coreboot lock the PAM registers instead of the FSP when the lockdown configuration is set to coreboot. TEST=boot to OS, read PCI 0:0.0 config register 0x80, value is 0x31 Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Change-Id: I0c3e16edeab6f85a79eb10e1477d95952b554a18 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57146 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subrata.banik@intel.com> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
parent
d87af79ace
commit
091dfa1ca0
|
@ -16,8 +16,10 @@
|
||||||
#include <intelblocks/lpc_lib.h>
|
#include <intelblocks/lpc_lib.h>
|
||||||
#include <intelblocks/pcr.h>
|
#include <intelblocks/pcr.h>
|
||||||
#include <intelblocks/pmclib.h>
|
#include <intelblocks/pmclib.h>
|
||||||
|
#include <intelblocks/systemagent.h>
|
||||||
#include <intelblocks/tco.h>
|
#include <intelblocks/tco.h>
|
||||||
#include <intelblocks/thermal.h>
|
#include <intelblocks/thermal.h>
|
||||||
|
#include <intelpch/lockdown.h>
|
||||||
#include <soc/p2sb.h>
|
#include <soc/p2sb.h>
|
||||||
#include <soc/pci_devs.h>
|
#include <soc/pci_devs.h>
|
||||||
#include <soc/pcr_ids.h>
|
#include <soc/pcr_ids.h>
|
||||||
|
@ -82,6 +84,12 @@ static void tbt_finalize(void)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void sa_finalize(void)
|
||||||
|
{
|
||||||
|
if (get_lockdown_config() == CHIPSET_LOCKDOWN_COREBOOT)
|
||||||
|
sa_lock_pam();
|
||||||
|
}
|
||||||
|
|
||||||
static void soc_finalize(void *unused)
|
static void soc_finalize(void *unused)
|
||||||
{
|
{
|
||||||
printk(BIOS_DEBUG, "Finalizing chipset.\n");
|
printk(BIOS_DEBUG, "Finalizing chipset.\n");
|
||||||
|
@ -89,6 +97,7 @@ static void soc_finalize(void *unused)
|
||||||
pch_finalize();
|
pch_finalize();
|
||||||
apm_control(APM_CNT_FINALIZE);
|
apm_control(APM_CNT_FINALIZE);
|
||||||
tbt_finalize();
|
tbt_finalize();
|
||||||
|
sa_finalize();
|
||||||
|
|
||||||
/* Indicate finalize step with post code */
|
/* Indicate finalize step with post code */
|
||||||
post_code(POST_OS_BOOT);
|
post_code(POST_OS_BOOT);
|
||||||
|
|
|
@ -406,6 +406,7 @@ static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg,
|
||||||
s_cfg->PchLockDownBiosInterface = lockdown_by_fsp;
|
s_cfg->PchLockDownBiosInterface = lockdown_by_fsp;
|
||||||
s_cfg->PchUnlockGpioPads = !lockdown_by_fsp;
|
s_cfg->PchUnlockGpioPads = !lockdown_by_fsp;
|
||||||
s_cfg->RtcMemoryLock = lockdown_by_fsp;
|
s_cfg->RtcMemoryLock = lockdown_by_fsp;
|
||||||
|
s_cfg->SkipPamLock = !lockdown_by_fsp;
|
||||||
|
|
||||||
/* coreboot will send EOP before loading payload */
|
/* coreboot will send EOP before loading payload */
|
||||||
s_cfg->EndOfPostMessage = EOP_DISABLE;
|
s_cfg->EndOfPostMessage = EOP_DISABLE;
|
||||||
|
|
Loading…
Reference in New Issue