GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

coreboot_tables: Print strapping IDs when adding them to coreboot table 

These used to be printed before CB:46605. Having them in the logs can be
a huge timesaver when debugging logs sent to you by other people
(especially from systems that don't boot all the way). Let's add them
back.

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ifdbfdd29d25a0937c27113ace776f7aec231a57d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52011
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Julius Werner 2021-03-31 18:30:29 -07:00
parent 45e103ca87
commit 0972871a23
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/lib/coreboot_table.c
View File

@ -19,6 +19,7 @@
#include <cbmem.h> #include <cbmem.h>
#include <bootmem.h> #include <bootmem.h>
#include <bootsplash.h> #include <bootsplash.h>
#include <inttypes.h>
#include <spi_flash.h> #include <spi_flash.h>
#include <smmstore.h> #include <smmstore.h>
@ -305,10 +306,20 @@ static struct lb_board_config *lb_board_config(struct lb_header *header)
config->tag = LB_TAG_BOARD_CONFIG; config->tag = LB_TAG_BOARD_CONFIG;
config->size = sizeof(*config); config->size = sizeof(*config);
const uint64_t fw_config = fw_config_get();
config->board_id = board_id(); config->board_id = board_id();
config->ram_code = ram_code(); config->ram_code = ram_code();
config->sku_id = sku_id(); config->sku_id = sku_id();
config->fw_config = pack_lb64(fw_config_get()); config->fw_config = pack_lb64(fw_config);
if (config->board_id != UNDEFINED_STRAPPING_ID)
printk(BIOS_INFO, "Board ID: %d\n", config->board_id);
if (config->ram_code != UNDEFINED_STRAPPING_ID)
printk(BIOS_INFO, "RAM code: %d\n", config->ram_code);
if (config->sku_id != UNDEFINED_STRAPPING_ID)
printk(BIOS_INFO, "SKU ID: %d\n", config->sku_id);
if (fw_config != UNDEFINED_FW_CONFIG)
printk(BIOS_INFO, "FW config: %#" PRIx64 "\n", fw_config);
return config; return config;
} }