google/cyan: Mark GpioInt() resources as PullDefault
Adapted from chromium commit 3750e09 [Strago: mark GpioInt() resources as PullDefault] coreboot considers GPIO resources first-class citizens and initializes all pads according to their intended use, with necessary pull settings applied. Therefore let's use PullDefault as pull qualifier in AML, letting the kernel know that it should not attempt to alter pull settings when using GPIOs. TEST=Built and booted on celes, cyan, and egdar; built for other cyan devices. Original-Change-Id: Iff58a324e73a7eeac9b38df05a095fcfe7acd31b Original-Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/898259 Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org> Change-Id: I0c69e77c58b8ceca71bc0c99e16d10c3e539f783 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/27760 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
73b723d7db
commit
0aa52739dd
|
@ -47,7 +47,7 @@ Scope (\_SB.PCI0.I2C2)
|
|||
"\\_SB.PCI0.I2C2", /* ResourceSource: I2C bus controller name */
|
||||
)
|
||||
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX }
|
||||
} )
|
||||
Return (SBUF)
|
||||
|
@ -91,7 +91,7 @@ Scope (\_SB.PCI0.I2C2)
|
|||
"\\_SB.PCI0.I2C2", /* ResourceSource: I2C bus controller name */
|
||||
)
|
||||
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPSW") { BOARD_JACK_TI_GPIO_INDEX }
|
||||
|
||||
} )
|
||||
|
@ -111,7 +111,7 @@ Scope (\_SB.PCI0.LPEA)
|
|||
Name (GBUF, ResourceTemplate ()
|
||||
{
|
||||
/* Jack Detect (index 0) */
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX }
|
||||
})
|
||||
}
|
||||
|
|
|
@ -39,7 +39,7 @@ Scope (\_SB.PCI0.I2C5)
|
|||
)
|
||||
|
||||
/* Jack Detect (index 0) */
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
|
||||
} )
|
||||
Return (SBUF)
|
||||
|
@ -57,7 +57,7 @@ Scope (\_SB.PCI0.LPEA)
|
|||
Name (GBUF, ResourceTemplate ()
|
||||
{
|
||||
/* Jack Detect (index 0) */
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
|
||||
})
|
||||
}
|
||||
|
|
|
@ -23,7 +23,7 @@ Scope (\_SB.GPNC)
|
|||
{
|
||||
Name (RBUF, ResourceTemplate ()
|
||||
{
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPNC") { BOARD_SCI_GPIO_INDEX }
|
||||
})
|
||||
Return (RBUF)
|
||||
|
|
|
@ -23,7 +23,7 @@
|
|||
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
|
||||
|
||||
/* Override default IRQ settings */
|
||||
#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,\
|
||||
#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,\
|
||||
"\\_SB.GPNC") { BOARD_I8042_GPIO_INDEX }
|
||||
|
||||
/* ACPI code for EC SuperIO functions */
|
||||
|
|
|
@ -35,7 +35,7 @@ Scope (\_SB.PCI0.I2C1)
|
|||
AddressingMode7Bit, /* AddressingMode */
|
||||
"\\_SB.PCI0.I2C1", /* ResourceSource */
|
||||
)
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
|
||||
|
||||
} )
|
||||
|
|
|
@ -35,7 +35,7 @@ Scope (\_SB.PCI0.I2C1)
|
|||
AddressingMode7Bit, /* AddressingMode */
|
||||
"\\_SB.I2C1", /* ResourceSource */
|
||||
)
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
|
||||
})
|
||||
Return (BUF0)
|
||||
|
|
|
@ -78,7 +78,7 @@ Scope (\_SB.PCI0.I2C1)
|
|||
AddressingMode7Bit, /* AddressingMode */
|
||||
"\\_SB.PCI0.I2C1", /* ResourceSource */
|
||||
)
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
|
||||
})
|
||||
Return (BUF0)
|
||||
|
|
|
@ -33,7 +33,7 @@ Scope (\_SB.PCI0.I2C6)
|
|||
AddressingMode7Bit, // AddressingMode
|
||||
"\\_SB.PCI0.I2C6", // ResourceSource
|
||||
)
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
|
||||
})
|
||||
|
||||
|
|
|
@ -32,7 +32,7 @@ Scope (\_SB.PCI0.I2C6)
|
|||
AddressingMode7Bit, /* AddressingMode */
|
||||
"\\_SB.PCI0.I2C6", /* ResourceSource */
|
||||
)
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
|
||||
GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
|
||||
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
|
||||
})
|
||||
|
||||
|
|
Loading…
Reference in New Issue