GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/block/lpc: Drop unnecessary helper function 

This patch removes unnecessary helper function pch_lpc_interrupt_init()
and directly uses soc_pch_pirq_init() function to avoid redundant
device NULL check.

TEST=Able to build and boot CML platform.

Change-Id: I3d11afb7e98f9b7f84beb2fdf308bbffeb3bbff7
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38952
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Aamir Bohra <aamir.bohra@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2020-02-18 11:20:30 +05:30 committed by Patrick Georgi
parent f71c6ae216
commit 0d866f8cd8
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/soc/intel/common/block/lpc/lpc_lib.c
View File

@ -270,17 +270,6 @@ static void lpc_set_gen_decode_range(
gen_io_dec[i]);
}
static void pch_lpc_interrupt_init(void)
{
const struct device *dev;
dev = pcidev_on_root(PCH_DEV_SLOT_LPC, 0);
if (!dev)
return;
soc_pch_pirq_init(dev);
}
void pch_enable_lpc(void)
{
/* Lookup device tree in romstage */
@ -295,7 +284,7 @@ void pch_enable_lpc(void)
lpc_set_gen_decode_range(gen_io_dec);
soc_setup_dmi_pcr_io_dec(gen_io_dec);
if (ENV_PAYLOAD_LOADER)
pch_lpc_interrupt_init();
soc_pch_pirq_init(dev);
}
void lpc_enable_pci_clk_cntl(void)