GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek/mt8188: Set pin drive strength to 8mA for NOR 

Set NOR pin drive to 8mA to comply with HW requirement.

This implementation is according to chapter 5.8 and 5.19 in MT8188
Functional Specification.

BUG=b:270911452
TEST=boot with following logs
[DEBUG]  mtk_snfc_init: got pin drive: 0x3
[DEBUG]  mtk_snfc_init: got pin drive: 0x3
[DEBUG]  mtk_snfc_init: got pin drive: 0x3
[DEBUG]  mtk_snfc_init: got pin drive: 0x3

Change-Id: If8344449f5b34cefcaaee6936e94f7f669c7148b
Signed-off-by: Jason Chen <Jason-ch.Chen@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74064
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jason Chen 2023-03-23 14:59:34 +08:00 committed by Rex-BC Chen
parent b7089e98e7
commit 132a3ab1a7
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/mediatek/mt8188/spi.c
View File

@ -6,6 +6,7 @@
*/ */
#include <assert.h> #include <assert.h>
#include <console/console.h>
#include <device/mmio.h> #include <device/mmio.h>
#include <gpio.h> #include <gpio.h>
#include <soc/addressmap.h> #include <soc/addressmap.h>
@ -105,6 +106,14 @@ void mtk_snfc_init(void)
for (size_t i = 0; i < ARRAY_SIZE(nor_pinmux); i++) { for (size_t i = 0; i < ARRAY_SIZE(nor_pinmux); i++) {
gpio_set_pull(ptr[i].gpio, GPIO_PULL_ENABLE, ptr[i].select); gpio_set_pull(ptr[i].gpio, GPIO_PULL_ENABLE, ptr[i].select);
gpio_set_mode(ptr[i].gpio, ptr[i].func); gpio_set_mode(ptr[i].gpio, ptr[i].func);
if (gpio_set_driving(ptr[i].gpio, GPIO_DRV_8_MA) < 0)
printk(BIOS_ERR,
"%s: failed to set pin drive to 8 mA for %d\n",
__func__, ptr[i].gpio.id);
else
printk(BIOS_DEBUG, "%s: got pin drive: %#x\n", __func__,
gpio_get_driving(ptr[i].gpio));
} }
} }