GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arm64: No need of invalidating cache line for secondary CPU stack 

With support for initializing registers based on values saved by primary CPU, we
no longer need to invalidate secondary CPU stack cache lines. Before jumping to
C environment, we enable caching and update the required registers.

BUG=chrome-os-partner:33962
BRANCH=None
TEST=Compiles and boots both CPU0 and CPU1 on ryu.

Change-Id: Ifee36302b5de25b909b4570a30ada8ecd742ab82
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 0a0403d06b89dae30b7520747501b0521d16a6db
Original-Signed-off-by: Furquan Shaikh <furquan@google.com>
Original-Change-Id: I738250f948e912725264cba3e389602af7510e3e
Original-Reviewed-on: https://chromium-review.googlesource.com/231563
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Tested-by: Furquan Shaikh <furquan@chromium.org>
Original-Commit-Queue: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: http://review.coreboot.org/9541
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Furquan Shaikh 2014-11-21 15:54:39 -08:00 committed by Patrick Georgi
parent 9482498003
commit 14b444b83b
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/arch/arm64/cpu_ramstage.c
View File

@ -151,13 +151,6 @@ static void init_cpu_info(struct bus *bus)
} }
} }
static void invalidate_cpu_stack_top(unsigned int id)
{
const size_t size = 128;
char *stack = cpu_get_stack(id);
dcache_invalidate_by_mva(stack - size, size);
}
void arch_initialize_cpus(device_t cluster, struct cpu_control_ops *cntrl_ops) void arch_initialize_cpus(device_t cluster, struct cpu_control_ops *cntrl_ops)
{ {
size_t max_cpus; size_t max_cpus;
@ -221,9 +214,6 @@ void arch_initialize_cpus(device_t cluster, struct cpu_control_ops *cntrl_ops)
/* Start the CPU. */ /* Start the CPU. */
printk(BIOS_DEBUG, "Starting CPU%x\n", ci->id); printk(BIOS_DEBUG, "Starting CPU%x\n", ci->id);
/* Ensure CPU's top of stack is not in the cache. */
invalidate_cpu_stack_top(ci->id);
if (cntrl_ops->start_cpu(ci->id, entry)) { if (cntrl_ops->start_cpu(ci->id, entry)) {
printk(BIOS_ERR, printk(BIOS_ERR,
"Failed to start CPU%x\n", ci->id); "Failed to start CPU%x\n", ci->id);