GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen 

The all shipped magolor and maglia has SSFC= 0x840.
The value is defined as 5M MIPI camera.But the value:0x840 will
conflict with the updated touchscreen field.
It will cause some touchscreen no function if make auto-update new
firmware.The CL would correct the field error.

The original fields:
CAMERA_WFC 38 40
TS_SOURCE  41 44

Correct fields:
MIPI Cam
  CAMERA_WFC 38 40
  CAMERA_UFC 41 42
  CAMERA_VCM 43 44
Touch-screen
  TS_SOURCE  45 48

The SSFC value of Magolor:
CAMERA_OVTI5675  5M AF (SSFC = 0x840)
CAMERA_OVTI8856  8M AF (SSFC = 0x880)

BUG=b:194639170
TEST=Build firmware and verify on camera and touch-screen devices

Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56685
Reviewed-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Ren Kuo 2021-08-02 14:31:35 +08:00 committed by Paul Fagerburg
parent 9fe70ed197
commit 163dfe68f6
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/mainboard/google/dedede/variants/magolor/overridetree.cb
View File

@ -1,10 +1,17 @@
fw_config fw_config
field CAMERA_WFC 38 40 field CAMERA_WFC 38 40
option CAMERA_NONE 0 option CAMERA_UNPROVISIONED 0
option CAMERA_OVTI5675 1 option CAMERA_OVTI5675 1
option CAMERA_OVTI8856 2 option CAMERA_OVTI8856 2
end end
field TS_SOURCE 41 44 field CAMERA_UFC 41 42
option CAMERA_UFC_UNPROVISIONED 0
end
field CAMERA_VCM 43 44
option CAMERA_VCM_UNPROVISIONED 0
option CAMERA_VCM0 1
end
field TS_SOURCE 45 48
option TS_UNPROVISIONED 0 option TS_UNPROVISIONED 0
option TS_ELAN_6915 1 option TS_ELAN_6915 1
option TS_ELAN_6918 2 option TS_ELAN_6918 2
@ -324,7 +331,7 @@ chip soc/intel/jasperlake
register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"
device i2c 36 on device i2c 36 on
probe CAMERA_WFC CAMERA_NONE probe CAMERA_WFC CAMERA_UNPROVISIONED
probe CAMERA_WFC CAMERA_OVTI5675 probe CAMERA_WFC CAMERA_OVTI5675
end end
end end
@ -381,8 +388,10 @@ chip soc/intel/jasperlake
register "pr0" = ""\\_SB.PCI0.I2C3.CAM0.PRIC"" register "pr0" = ""\\_SB.PCI0.I2C3.CAM0.PRIC""
register "vcm_compat" = ""dongwoon,dw9714"" register "vcm_compat" = ""dongwoon,dw9714""
device i2c 0C on end device i2c 0C on
probe CAMERA_VCM CAMERA_VCM_UNPROVISIONED
probe CAMERA_VCM CAMERA_VCM0
end
end end
chip drivers/intel/mipi_camera chip drivers/intel/mipi_camera
register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"