GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

{lynxpoint,broadwell}/hda_verb.c: Drop effect-free write 

This bit is hardwired to 1 (Intel High Definition Audio mode).

Change-Id: I3683497c5e2446f1d8319037583890b5d0a8a95c
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51644
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Angel Pons 2021-03-18 17:39:25 +01:00
parent 50811e2deb
commit 1895d1a181
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/broadwell/pch/hda.c
View File

@ -60,10 +60,6 @@ static void hda_pch_init(struct device *dev, u8 *base)
reg32 |= (1 << 24);
pci_write_config32(dev, 0xc4, reg32);
reg8 = pci_read_config8(dev, 0x40); // Audio Control
reg8 |= 1; // Select HDA mode
pci_write_config8(dev, 0x40, reg8);
reg8 = pci_read_config8(dev, 0x4d); // Docking Status
reg8 &= ~(1 << 7); // Docking not supported
pci_write_config8(dev, 0x4d, reg8);

3
src/southbridge/intel/lynxpoint/azalia.c
View File

@ -81,9 +81,6 @@ static void azalia_pch_init(struct device *dev, u8 *base)
if (!pch_is_lp())
pci_and_config32(dev, 0xd0, ~(1 << 31));
// Select Azalia mode
pci_or_config8(dev, 0x40, 1); // Audio Control
// Docking not supported
pci_and_config8(dev, 0x4d, (u8)~(1 << 7)); // Docking Status