GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stoneyridge: Correct bugs in lpc.c 

Remove the bridge enable step of accessing D14F0x64.  This method for
enabling the bridge appears to be last present in the SB700 device.
Beginning in the SB800 (and all FCH, SoC devices), the enable is in
PMxEC[0].  Since the bridge is enabled in bootblock to allow port 80h,
there is no need to maintain it in ramstage.

Correct the device used for misc. configuration of the LPC bridge.
The #defined value removed is 14.0 but the settings are in 14.3.

TEST=Boot Grunt, check console and dmesg for errors and warnings
BUG=b:131862871

Change-Id: I078be974dc3c78c94cb7c0832518f21bac029ff2
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32551
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
This commit is contained in:
Marshall Dawson 2019-05-02 18:56:54 -06:00 committed by Patrick Georgi
parent e09caf6428
commit 1bc04e3c3e
1 changed files with 13 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/soc/amd/stoneyridge/lpc.c
View File

@ -35,31 +35,22 @@
static void lpc_init(struct device *dev) static void lpc_init(struct device *dev)
{ {
u8 byte; u8 byte;
u32 dword;
/*
* Enable the LPC Controller
* SMBus register 0x64 is not defined in public datasheet.
*/
dword = pci_read_config32(SOC_SMBUS_DEV, 0x64);
dword |= 1 << 20;
pci_write_config32(SOC_SMBUS_DEV, 0x64, dword);
/* Initialize isa dma */ /* Initialize isa dma */
isa_dma_init(); isa_dma_init();
/* Enable DMA transaction on the LPC bus */ /* Enable DMA transaction on the LPC bus */
byte = pci_read_config8(SOC_SMBUS_DEV, LPC_PCI_CONTROL); byte = pci_read_config8(dev, LPC_PCI_CONTROL);
byte |= LEGACY_DMA_EN; byte |= LEGACY_DMA_EN;
pci_write_config8(SOC_SMBUS_DEV, LPC_PCI_CONTROL, byte); pci_write_config8(dev, LPC_PCI_CONTROL, byte);
/* Disable the timeout mechanism on LPC */ /* Disable the timeout mechanism on LPC */
byte = pci_read_config8(SOC_SMBUS_DEV, LPC_IO_OR_MEM_DECODE_ENABLE); byte = pci_read_config8(dev, LPC_IO_OR_MEM_DECODE_ENABLE);
byte &= ~LPC_SYNC_TIMEOUT_COUNT_ENABLE; byte &= ~LPC_SYNC_TIMEOUT_COUNT_ENABLE;
pci_write_config8(SOC_SMBUS_DEV, LPC_IO_OR_MEM_DECODE_ENABLE, byte); pci_write_config8(dev, LPC_IO_OR_MEM_DECODE_ENABLE, byte);
/* Disable LPC MSI Capability */ /* Disable LPC MSI Capability */
byte = pci_read_config8(SOC_SMBUS_DEV, LPC_MISC_CONTROL_BITS); byte = pci_read_config8(dev, LPC_MISC_CONTROL_BITS);
/* BIT 1 is not defined in public datasheet. */ /* BIT 1 is not defined in public datasheet. */
byte &= ~(1 << 1); byte &= ~(1 << 1);
@ -69,15 +60,15 @@ static void lpc_init(struct device *dev)
* interrupt and visit LPC. * interrupt and visit LPC.
*/ */
byte &= ~LPC_NOHOG; byte &= ~LPC_NOHOG;
pci_write_config8(SOC_SMBUS_DEV, LPC_MISC_CONTROL_BITS, byte); pci_write_config8(dev, LPC_MISC_CONTROL_BITS, byte);
/* /*
* Enable hand-instance of the pulse generator and SPI * Enable hand-instance of the pulse generator and SPI
* controller prefetch of flash. * controller prefetch of flash.
*/ */
byte = pci_read_config8(SOC_SMBUS_DEV, LPC_HOST_CONTROL); byte = pci_read_config8(dev, LPC_HOST_CONTROL);
byte |= PREFETCH_EN_SPI_FROM_HOST | T_START_ENH; byte |= PREFETCH_EN_SPI_FROM_HOST | T_START_ENH;
pci_write_config8(SOC_SMBUS_DEV, LPC_HOST_CONTROL, byte); pci_write_config8(dev, LPC_HOST_CONTROL, byte);
cmos_check_update_date(); cmos_check_update_date();
@ -161,9 +152,8 @@ static void lpc_set_resources(struct device *dev)
pci_dev_set_resources(dev); pci_dev_set_resources(dev);
} }
static void set_child_resource(struct device *child, static void set_child_resource(struct device *dev, struct device *child,
u32 *reg, u32 *reg, u32 *reg_x)
u32 *reg_x)
{ {
struct resource *res; struct resource *res;
u32 base, end; u32 base, end;
@ -272,7 +262,7 @@ static void set_child_resource(struct device *child,
wideio_index = sb_set_wideio_range(base, res->size); wideio_index = sb_set_wideio_range(base, res->size);
if (wideio_index != WIDEIO_RANGE_ERROR) { if (wideio_index != WIDEIO_RANGE_ERROR) {
/* preserve wide IO related bits. */ /* preserve wide IO related bits. */
*reg_x = pci_read_config32(SOC_LPC_DEV, *reg_x = pci_read_config32(dev,
LPC_IO_OR_MEM_DECODE_ENABLE); LPC_IO_OR_MEM_DECODE_ENABLE);
printk(BIOS_DEBUG, printk(BIOS_DEBUG,
@ -308,11 +298,8 @@ static void lpc_enable_childrens_resources(struct device *dev)
for (child = link->children; child; for (child = link->children; child;
child = child->sibling) { child = child->sibling) {
if (child->enabled if (child->enabled
&& (child->path.type == DEVICE_PATH_PNP)) { && (child->path.type == DEVICE_PATH_PNP))
set_child_resource(child, set_child_resource(dev, child, &reg, &reg_x);
&reg,
&reg_x);
}
} }
} }
pci_write_config32(dev, LPC_IO_PORT_DECODE_ENABLE, reg); pci_write_config32(dev, LPC_IO_PORT_DECODE_ENABLE, reg);