soc/intel/apollolake: Add handling of GNVS ACPI entry for CHROMEOS builds

Add chromeos required GNVS feature. The GNVS table stays in both CBMEM
and ACPI DSDT tables.

Change-Id: I4db0eb18d2de62917a94704318a7896c04e4777f
Signed-off-by: Andrey Petrov <andrey.petrov@intel.com>
Reviewed-on: https://review.coreboot.org/14471
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Lance Zhao 2016-04-19 18:04:21 -07:00 committed by Aaron Durbin
parent 164e8f1d9b
commit 1bd0c0c497
6 changed files with 110 additions and 0 deletions

View File

@ -16,12 +16,15 @@
*/ */
#include <arch/acpi.h> #include <arch/acpi.h>
#include <arch/acpigen.h>
#include <arch/ioapic.h> #include <arch/ioapic.h>
#include <arch/smp/mpspec.h> #include <arch/smp/mpspec.h>
#include <cbmem.h>
#include <cpu/x86/smm.h> #include <cpu/x86/smm.h>
#include <soc/acpi.h> #include <soc/acpi.h>
#include <soc/iomap.h> #include <soc/iomap.h>
#include <soc/pm.h> #include <soc/pm.h>
#include <soc/nvs.h>
unsigned long acpi_fill_mcfg(unsigned long current) unsigned long acpi_fill_mcfg(unsigned long current)
{ {
@ -125,3 +128,29 @@ unsigned long southbridge_write_acpi_tables(device_t device,
{ {
return acpi_write_hpet(device, current, rsdp); return acpi_write_hpet(device, current, rsdp);
} }
static void acpi_create_gnvs(struct global_nvs_t *gnvs)
{
if (IS_ENABLED(CONFIG_CHROMEOS)) {
/* Initialize Verified Boot data */
chromeos_init_vboot(&gnvs->chromeos);
gnvs->chromeos.vbt2 = ACTIVE_ECFW_RO;
}
}
void southbridge_inject_dsdt(device_t device)
{
struct global_nvs_t *gnvs;
gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS);
if (gnvs) {
acpi_create_gnvs(gnvs);
acpi_save_gnvs((uintptr_t)gnvs);
/* Add it to DSDT. */
acpigen_write_scope("\\");
acpigen_write_name_dword("NVSA", (uintptr_t)gnvs);
acpigen_pop_len();
}
}

View File

@ -0,0 +1,35 @@
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2016 Intel Corp.
* (Written by Alexandru Gagniuc <alexandrux.gagniuc@intel.com> for Intel Corp.)
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
/*
* NOTE: The layout of the GNVS structure below must match the layout in
* soc/intel/apollolake/include/soc/nvs.h !!!
*
*/
External (NVSA)
OperationRegion (GNVS, SystemMemory, NVSA, 0x1000)
Field (GNVS, ByteAcc, NoLock, Preserve)
{
/* Nothing here yet, folks */
Offset (0x00),
/* ChromeOS stuff (0x100 -> 0xfff, size 0xeff) */
Offset (0x100),
#include <vendorcode/google/chromeos/acpi/gnvs.asl>
}

View File

@ -17,6 +17,7 @@
*/ */
#include <bootstate.h> #include <bootstate.h>
#include <cbmem.h>
#include <console/console.h> #include <console/console.h>
#include <cpu/cpu.h> #include <cpu/cpu.h>
#include <device/device.h> #include <device/device.h>
@ -26,6 +27,7 @@
#include <memrange.h> #include <memrange.h>
#include <soc/iomap.h> #include <soc/iomap.h>
#include <soc/cpu.h> #include <soc/cpu.h>
#include <soc/nvs.h>
#include <soc/pci_devs.h> #include <soc/pci_devs.h>
#include "chip.h" #include "chip.h"
@ -65,11 +67,15 @@ static void enable_dev(device_t dev)
static void soc_init(void *data) static void soc_init(void *data)
{ {
struct range_entry range; struct range_entry range;
struct global_nvs_t *gnvs;
/* TODO: tigten this resource range */ /* TODO: tigten this resource range */
/* TODO: fix for S3 resume, as this would corrupt OS memory */ /* TODO: fix for S3 resume, as this would corrupt OS memory */
range_entry_init(&range, 0x200000, 4ULL*GiB, 0); range_entry_init(&range, 0x200000, 4ULL*GiB, 0);
fsp_silicon_init(&range); fsp_silicon_init(&range);
/* Allocate ACPI NVS in CBMEM */
gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(*gnvs));
} }
void platform_fsp_silicon_init_params_cb(struct FSPS_UPD *silupd) void platform_fsp_silicon_init_params_cb(struct FSPS_UPD *silupd)

View File

@ -25,4 +25,6 @@ void soc_fill_common_fadt(acpi_fadt_t * fadt);
unsigned long southbridge_write_acpi_tables(device_t device, unsigned long southbridge_write_acpi_tables(device_t device,
unsigned long current, struct acpi_rsdp *rsdp); unsigned long current, struct acpi_rsdp *rsdp);
void southbridge_inject_dsdt(device_t device);
#endif /* _SOC_APOLLOLAKE_ACPI_H_ */ #endif /* _SOC_APOLLOLAKE_ACPI_H_ */

View File

@ -0,0 +1,37 @@
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2015 Intel Corp.
* (Written by Lance Zhao <lijian.zhao@intel.com> for Intel Corp.)
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
/*
* NOTE: The layout of the global_nvs_t structure below must match the layout
* in soc/intel/apollolake/acpi/globalnvs.asl !!!
*
*/
#ifndef _SOC_APOLLOLAKE_NVS_H_
#define _SOC_APOLLOLAKE_NVS_H_
#include <vendorcode/google/chromeos/gnvs.h>
struct global_nvs_t {
/* Miscellaneous */
uint8_t unused[256];
/* ChromeOS specific (0x100 - 0xfff) */
chromeos_acpi_t chromeos;
} __attribute__((packed));
#endif /* _SOC_APOLLOLAKE_NVS_H_ */

View File

@ -86,6 +86,7 @@ static struct device_operations device_ops = {
.set_resources = &pci_dev_set_resources, .set_resources = &pci_dev_set_resources,
.enable_resources = &pci_dev_enable_resources, .enable_resources = &pci_dev_enable_resources,
.write_acpi_tables = southbridge_write_acpi_tables, .write_acpi_tables = southbridge_write_acpi_tables,
.acpi_inject_dsdt_generator = southbridge_inject_dsdt,
.init = &lpc_init .init = &lpc_init
}; };