intel/apollolake: Fix typo in gpi_status_get
sts_index is calculated incorrectly because of wrong use of parenthesis. This lead to wrong bit being checked for EC_SMI_GPI on reef and lidclose event was missed. BUG=chrome-os-partner:56395 BRANCH=None TEST=Verified that lidclose event is seen and handled by SMM in coreboot on reef. Change-Id: I56be4aaf30e2d6712fc597b941206ca59ffaa915 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/16256 Tested-by: build bot (Jenkins) Reviewed-by: Shaunak Saha <shaunak.saha@intel.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
parent
986c658c41
commit
200f11eb87
|
@ -328,7 +328,7 @@ int gpi_status_get(const struct gpi_status *sts, gpio_t gpi)
|
||||||
if (comm == NULL)
|
if (comm == NULL)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
sts_index = comm->gpi_offset + (gpi - (comm->first_pad) /
|
sts_index = comm->gpi_offset + ((gpi - comm->first_pad) /
|
||||||
GPIO_MAX_NUM_PER_GROUP);
|
GPIO_MAX_NUM_PER_GROUP);
|
||||||
|
|
||||||
return !!(sts->grp[sts_index] & (1 << (gpi % GPIO_MAX_NUM_PER_GROUP)));
|
return !!(sts->grp[sts_index] & (1 << (gpi % GPIO_MAX_NUM_PER_GROUP)));
|
||||||
|
|
Loading…
Reference in New Issue