GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes 

The double quotes around the remaining shell parameters '${@:2}' causes
that the provided *.h files in $(CONFIG_CPU_MICROCODE_HEADER_FILES),
which is a space separated list, cannot be broken down to every single
file as needed but stay as a single parameter in the for-loop.
Therefore, the called function 'include_file' will get a single
parameter with all files which will lead to a broken C code in
terms of a wrong #include-syntax. This causes the script to fail.

To fix this remove the double quotes which works just fine.

Change-Id: Iab7b0dc8d850973d6af764899907d383e9ec7743
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40565
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Werner Zeh 2020-04-21 11:03:11 +02:00 committed by Patrick Georgi
parent abaa1de93b
commit 21530bd421
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/scripts/ucode_h_to_bin.sh
View File

@ -49,7 +49,7 @@ include_file() {
fi fi
} }
for UCODE in "${@:2}"; do for UCODE in ${@:2}; do
if [ -d "$UCODE" ]; then if [ -d "$UCODE" ]; then
for f in "$UCODE/"*.inc for f in "$UCODE/"*.inc
do do