GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/lenovo/h8: Fix IASL warnings 

If any path in a method returns a value, IASL expects that all paths
within that method will return a value.

Presumably the MKHP method wouldn't get called unless there were a
pending event, but if no event is found, return a zero.

Fixes IASL warning:
dsdt.aml 1785: Method (MHKP, 0, NotSerialized)
Warning 3115 -           ^ Not all control paths return a value (MHKP)

This was the only IASL warning in most lenovo mainboards.

Change-Id: Id93dcc4a74bd4c18b78f1dde821e7ba0f3444da3
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12517
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Martin Roth 2015-11-23 12:23:19 -07:00
parent 56033a9f2d
commit 21dbc2fc3c
12 changed files with 1 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ec/lenovo/h8/acpi/ec.asl
View File

@ -300,6 +300,7 @@ Device(EC)
Add (Local0, 0x5000, Local0) Add (Local0, 0x5000, Local0)
Return (Local0) Return (Local0)
} }
Return (Zero)
} }
/* Report event */ /* Report event */
Method (RHK, 1, NotSerialized) { Method (RHK, 1, NotSerialized) {

4
src/mainboard/lenovo/r400/Kconfig
View File

@ -4,8 +4,4 @@ config MAINBOARD_PART_NUMBER
string string
default "ThinkPad R400" default "ThinkPad R400"
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif endif

4
src/mainboard/lenovo/t420s/Kconfig
View File

@ -73,8 +73,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex hex
default 0x21d2 default 0x21d2
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_T420S endif # BOARD_LENOVO_T420S

4
src/mainboard/lenovo/t430s/Kconfig
View File

@ -70,8 +70,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex hex
default 0x21fb default 0x21fb
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_T430S endif # BOARD_LENOVO_T430S

4
src/mainboard/lenovo/t520/Kconfig
View File

@ -73,8 +73,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex hex
default 0x21cf default 0x21cf
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_T520 endif # BOARD_LENOVO_T520

4
src/mainboard/lenovo/t530/Kconfig
View File

@ -71,8 +71,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex hex
default 0x21fa default 0x21fa
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_T530 endif # BOARD_LENOVO_T530

4
src/mainboard/lenovo/t60/Kconfig
View File

@ -54,8 +54,4 @@ config SEABIOS_PS2_TIMEOUT
int int
default 3000 default 3000
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif endif

4
src/mainboard/lenovo/x200/Kconfig
View File

@ -48,8 +48,4 @@ config CBFS_SIZE
hex hex
default 0x200000 default 0x200000
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_X200 endif # BOARD_LENOVO_X200

4
src/mainboard/lenovo/x201/Kconfig
View File

@ -49,8 +49,4 @@ config CPU_ADDR_BITS
int int
default 36 default 36
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif endif

4
src/mainboard/lenovo/x220/Kconfig
View File

@ -74,8 +74,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex hex
default 0x21db default 0x21db
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_X220 endif # BOARD_LENOVO_X220

4
src/mainboard/lenovo/x230/Kconfig
View File

@ -74,8 +74,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex hex
default 0x21fa default 0x21fa
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LENOVO_X230 endif # BOARD_LENOVO_X230

4
src/mainboard/lenovo/x60/Kconfig
View File

@ -61,8 +61,4 @@ config SEABIOS_PS2_TIMEOUT
int int
default 3000 default 3000
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif endif