GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio 

ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID
object or an _ADR object, but should not contain both."

Found-by: ACPICA 20191018
Change-Id: I9f55cc033b5672917520b139444bc614462c4a05
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36261
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Elyes HAOUAS 2019-10-23 15:19:08 +02:00 committed by Patrick Georgi
parent ea4bda55d6
commit 24cd6c897b
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/apollolake/acpi/gpio.asl
View File

@ -23,7 +23,6 @@ scope (\_SB) {
Device (GPO0) Device (GPO0)
{ {
Name (_ADR, 0)
Name (_HID, GPIO_COMM_NAME) Name (_HID, GPIO_COMM_NAME)
Name (_CID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME)
Name (_DDN, GPIO_COMM_0_DESC) Name (_DDN, GPIO_COMM_0_DESC)
@ -54,7 +53,6 @@ scope (\_SB) {
Device (GPO1) Device (GPO1)
{ {
Name (_ADR, 0)
Name (_HID, GPIO_COMM_NAME) Name (_HID, GPIO_COMM_NAME)
Name (_CID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME)
Name (_DDN, GPIO_COMM_1_DESC) Name (_DDN, GPIO_COMM_1_DESC)
@ -85,7 +83,6 @@ scope (\_SB) {
Device (GPO2) Device (GPO2)
{ {
Name (_ADR, 0)
Name (_HID, GPIO_COMM_NAME) Name (_HID, GPIO_COMM_NAME)
Name (_CID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME)
Name (_DDN, GPIO_COMM_2_DESC) Name (_DDN, GPIO_COMM_2_DESC)
@ -116,7 +113,6 @@ scope (\_SB) {
Device (GPO3) Device (GPO3)
{ {
Name (_ADR, 0)
Name (_HID, GPIO_COMM_NAME) Name (_HID, GPIO_COMM_NAME)
Name (_CID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME)
Name (_DDN, GPIO_COMM_3_DESC) Name (_DDN, GPIO_COMM_3_DESC)