GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/nsc/pc87360: Use link-time symbol over .c includes 

Change-Id: Id6d9efc93fdaff63dcaab50712ac9be35ccb42a7
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8053
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan 2015-01-04 04:09:55 +11:00
parent 74834e0758
commit 24fb03e767
6 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/arima/hdama/romstage.c
View File

@ -12,7 +12,7 @@
#include "lib/delay.c" #include "lib/delay.c"
#include "northbridge/amd/amdk8/reset_test.c" #include "northbridge/amd/amdk8/reset_test.c"
#include "northbridge/amd/amdk8/debug.c" #include "northbridge/amd/amdk8/debug.c"
#include "superio/nsc/pc87360/early_serial.c" #include <superio/nsc/pc87360/pc87360.h>
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include "northbridge/amd/amdk8/setup_resource_map.c" #include "northbridge/amd/amdk8/setup_resource_map.c"
#include <spd.h> #include <spd.h>

2
src/mainboard/hp/e_vectra_p2706t/romstage.c
View File

@ -25,7 +25,7 @@
#include <stdlib.h> #include <stdlib.h>
#include <console/console.h> #include <console/console.h>
/* TODO: It's a PC87364 actually! */ /* TODO: It's a PC87364 actually! */
#include "superio/nsc/pc87360/early_serial.c" #include <superio/nsc/pc87360/pc87360.h>
/* TODO: It's i810E actually! */ /* TODO: It's i810E actually! */
#include "northbridge/intel/i82810/raminit.h" #include "northbridge/intel/i82810/raminit.h"
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"

1
src/superio/nsc/pc87360/Makefile.inc
View File

@ -19,4 +19,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_NSC_PC87360) += early_serial.c
ramstage-$(CONFIG_SUPERIO_NSC_PC87360) += superio.c ramstage-$(CONFIG_SUPERIO_NSC_PC87360) += superio.c

4
src/superio/nsc/pc87360/early_serial.c
View File

@ -20,9 +20,11 @@
*/ */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include <stdint.h>
#include "pc87360.h" #include "pc87360.h"
static void pc87360_enable_serial(pnp_devfn_t dev, u16 iobase) void pc87360_enable_serial(pnp_devfn_t dev, u16 iobase)
{ {
pnp_set_logical_device(dev); pnp_set_logical_device(dev);
pnp_set_enable(dev, 0); pnp_set_enable(dev, 0);

11
src/superio/nsc/pc87360/pc87360.h
View File

@ -19,8 +19,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#ifndef SUPERIO_NSC_PC87360_PC87360_H #ifndef SUPERIO_NSC_PC87360_H
#define SUPERIO_NSC_PC87360_PC87360_H #define SUPERIO_NSC_PC87360_H
#define PC87360_FDC 0x00 /* Floppy */ #define PC87360_FDC 0x00 /* Floppy */
#define PC87360_PP 0x01 /* Parallel port */ #define PC87360_PP 0x01 /* Parallel port */
@ -34,4 +34,9 @@
#define PC87360_FSCM 0x09 #define PC87360_FSCM 0x09
#define PC87360_WDT 0x0A #define PC87360_WDT 0x0A
#endif #include <arch/io.h>
#include <stdint.h>
void pc87360_enable_serial(pnp_devfn_t dev, u16 iobase);
#endif /* SUPERIO_NSC_PC87360_H */

1
src/superio/nsc/pc87360/superio.c
View File

@ -30,7 +30,6 @@
static void init(struct device *dev) static void init(struct device *dev)
{ {
if (!dev->enabled) if (!dev->enabled)
return; return;