GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0: Print return value when dying 

When coreboot goes to die because FSP returned an error, log the return
value in the message printed by `die()` or `die_with_post_code()`.

Change-Id: I6b9ea60534a20429f15132007c1f5770760481af
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60637
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Angel Pons 2022-01-01 17:20:00 +01:00 committed by Subrata Banik
parent 346bb0b010
commit 2b1f8d4129
3 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/drivers/intel/fsp2_0/memory_init.c
View File

@ -309,9 +309,8 @@ static void do_fsp_memory_init(const struct fspm_context *context, bool s3wake)
/* Handle any errors returned by FspMemoryInit */ /* Handle any errors returned by FspMemoryInit */
fsp_handle_reset(status); fsp_handle_reset(status);
if (status != FSP_SUCCESS) { if (status != FSP_SUCCESS) {
printk(BIOS_CRIT, "FspMemoryInit returned 0x%08x\n", status);
die_with_post_code(POST_RAM_FAILURE, die_with_post_code(POST_RAM_FAILURE,
"FspMemoryInit returned an error!\n"); "FspMemoryInit returned with error 0x%08x!\n", status);
} }
do_fsp_post_memory_init(s3wake, fsp_version); do_fsp_post_memory_init(s3wake, fsp_version);

6
src/drivers/intel/fsp2_0/notify.c
View File

@ -50,10 +50,8 @@ static void fsp_notify(enum fsp_notify_phase phase)
/* Handle any errors returned by FspNotify */ /* Handle any errors returned by FspNotify */
fsp_handle_reset(ret); fsp_handle_reset(ret);
if (ret != FSP_SUCCESS) { if (ret != FSP_SUCCESS)
printk(BIOS_SPEW, "FspNotify returned 0x%08x\n", ret); die("FspNotify returned with error 0x%08x!\n", ret);
die("FspNotify returned an error!\n");
}
/* Allow the platform to run something after FspNotify */ /* Allow the platform to run something after FspNotify */
platform_fsp_notify_status(phase); platform_fsp_notify_status(phase);

6
src/drivers/intel/fsp2_0/temp_ram_exit.c
View File

@ -29,10 +29,8 @@ static void fsp_temp_ram_exit(void)
printk(BIOS_DEBUG, "Calling TempRamExit: %p\n", temp_ram_exit); printk(BIOS_DEBUG, "Calling TempRamExit: %p\n", temp_ram_exit);
status = temp_ram_exit(NULL); status = temp_ram_exit(NULL);
if (status != FSP_SUCCESS) { if (status != FSP_SUCCESS)
printk(BIOS_CRIT, "TempRamExit returned 0x%08x\n", status); die("TempRamExit returned with error 0x%08x!\n", status);
die("TempRamExit returned an error!\n");
}
cbfs_unmap(mapping); cbfs_unmap(mapping);
} }