GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/alderlake: Add IBECC 

Add In Band Error Correction Code to Alderlake SOC's.
It's currently needed and tested for the Prodrive Atlas mainboard.
After enabling it in the UPD, FSP-M takes care of enabling IBECC.

Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com>
Change-Id: I9cc2ed6defa1223aa422b9b0d8145f8f8b3dd12e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68756
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Maximilian Brune 2022-10-24 20:31:18 +02:00 committed by Felix Held
parent ffc79fbe27
commit 2c984883ec
2 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/soc/intel/alderlake/chip.h
View File

@ -20,6 +20,25 @@
#include <soc/vr_config.h> #include <soc/vr_config.h>
#include <stdint.h> #include <stdint.h>
/* Define config parameters for In-Band ECC (IBECC). */
#define MAX_IBECC_REGIONS 8
/* In-Band ECC Operation Mode */
enum ibecc_mode {
IBECC_MODE_PER_REGION,
IBECC_MODE_NONE,
IBECC_MODE_ALL
};
struct ibecc_config {
bool enable;
enum ibecc_mode mode;
bool range_enable[MAX_IBECC_REGIONS];
uint16_t range_base[MAX_IBECC_REGIONS];
uint16_t range_mask[MAX_IBECC_REGIONS];
/* add ECC error injection if needed by a mainboard */
};
/* Types of different SKUs */ /* Types of different SKUs */
enum soc_intel_alderlake_power_limits { enum soc_intel_alderlake_power_limits {
ADL_P_142_242_282_15W_CORE, ADL_P_142_242_282_15W_CORE,
@ -273,6 +292,9 @@ struct soc_intel_alderlake_config {
/* TCC activation offset */ /* TCC activation offset */
uint32_t tcc_offset; uint32_t tcc_offset;
/* In-Band ECC (IBECC) configuration */
struct ibecc_config ibecc;
/* System Agent dynamic frequency support. Only effects ULX/ULT CPUs. /* System Agent dynamic frequency support. Only effects ULX/ULT CPUs.
* When enabled memory will be training at two different frequencies. * When enabled memory will be training at two different frequencies.
* 0:Disabled, 1:FixedPoint0, 2:FixedPoint1, 3:FixedPoint2, * 0:Disabled, 1:FixedPoint0, 2:FixedPoint1, 3:FixedPoint2,

19
src/soc/intel/alderlake/romstage/fsp_params.c
View File

@ -342,6 +342,24 @@ static void fill_fspm_trace_params(FSP_M_CONFIG *m_cfg,
m_cfg->CpuCrashLogEnable = m_cfg->CpuCrashLogDevice; m_cfg->CpuCrashLogEnable = m_cfg->CpuCrashLogDevice;
} }
static void fill_fspm_ibecc_params(FSP_M_CONFIG *m_cfg,
const struct soc_intel_alderlake_config *config)
{
/* In-Band ECC configuration */
if (config->ibecc.enable) {
m_cfg->Ibecc = config->ibecc.enable;
m_cfg->IbeccOperationMode = config->ibecc.mode;
if (m_cfg->IbeccOperationMode == IBECC_MODE_PER_REGION) {
FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeEnable,
config->ibecc.range_enable);
FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeBase,
config->ibecc.range_base);
FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeMask,
config->ibecc.range_mask);
}
}
}
static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, static void soc_memory_init_params(FSP_M_CONFIG *m_cfg,
const struct soc_intel_alderlake_config *config) const struct soc_intel_alderlake_config *config)
{ {
@ -362,6 +380,7 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg,
fill_fspm_usb4_params, fill_fspm_usb4_params,
fill_fspm_vtd_params, fill_fspm_vtd_params,
fill_fspm_trace_params, fill_fspm_trace_params,
fill_fspm_ibecc_params,
}; };
for (size_t i = 0; i < ARRAY_SIZE(fill_fspm_params); i++) for (size_t i = 0; i < ARRAY_SIZE(fill_fspm_params); i++)