GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bimgtool: initialize data header 

Otherwise dummy contains uninitialized data, which leads to non-reproducible
builds (and a leak of 4 bytes of stack data).

Change-Id: Iaaf846580ec436fdd4f0800c7576b544f50d6ae0
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: http://review.coreboot.org/10524
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Patrick Georgi 2015-06-12 11:04:49 +02:00 committed by Patrick Georgi
parent f75c3b4b6a
commit 2d119a3f01
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/bimgtool/bimgtool.c
View File

@ -160,7 +160,7 @@ static const struct crc_t crc_type = {
static int write_binary(FILE *out, FILE *in, struct bimg_header *hdr) static int write_binary(FILE *out, FILE *in, struct bimg_header *hdr)
{ {
static uint8_t file_buf[MAX_RECORD_BYTES]; static uint8_t file_buf[MAX_RECORD_BYTES];
struct bimg_data_header data_hdr; struct bimg_data_header data_hdr = { 0 };
size_t n_written; size_t n_written;
data_hdr.dest_addr = hdr->entry_addr; data_hdr.dest_addr = hdr->entry_addr;