GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/amd/pi/northbridge.c: Remove superfluous logic operand 

The "((1ull << (sizeof(modules) * 8)) - 1)" statement evaluates to
0xffffffff, but there's no need to AND with that value, as 'modules'
is already 32-bit. The '&&' is most likely a typo, which meant bitwise
and, as indicated by the structure of thus operation.

Remove this superfluous statement. This also fixes a clang warning.

Change-Id: Ie55bd9f8b0ec5fd41e440f56dcedd40c830bf826
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/7965
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Alexandru Gagniuc 2014-12-28 20:38:32 -06:00
parent 4851bf2822
commit 2e0cf14e14
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/amd/pi/00730F01/northbridge.c
View File

@ -901,7 +901,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
printk(BIOS_SPEW, "MullinsPI Debug: Grabbing the AMD Topology Information.\n"); printk(BIOS_SPEW, "MullinsPI Debug: Grabbing the AMD Topology Information.\n");
AmdGetValue(AMD_GLOBAL_USER_OPTIONS, (VOID**)&options, sizeof(options)); AmdGetValue(AMD_GLOBAL_USER_OPTIONS, (VOID**)&options, sizeof(options));
AmdGetValue(AMD_GLOBAL_NUM_MODULES, &modules_ptr, sizeof(modules)); AmdGetValue(AMD_GLOBAL_NUM_MODULES, &modules_ptr, sizeof(modules));
modules = (*(u32*)modules_ptr) && ((1ull << (sizeof(modules) * 8)) - 1); modules = *(u32*)modules_ptr;
ASSERT(modules > 0); ASSERT(modules > 0);
ASSERT(options); ASSERT(options);
ioapic_count = (int)options->CfgPlatNumIoApics; ioapic_count = (int)options->CfgPlatNumIoApics;