haswell: relocate `romstage_common` to northbridge

Other platforms do this as well. It will ease refactoring on follow-ups.

Change-Id: I643982a58c6f5370c78acef93740f27df001a06d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43093
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tristan Corrick <tristan@corrick.kiwi>

src/cpu/intel/haswell/Makefile.inc

@@ -1,5 +1,4 @@
 ramstage-y += haswell_init.c
-romstage-y += romstage.c
 romstage-y += ../car/romstage.c
 
 ramstage-y += acpi.c

src/cpu/intel/haswell/haswell.h

@@ -118,16 +118,6 @@
 # error "CONFIG_IED_REGION_SIZE is not a power of 2"
 #endif
 
-struct pei_data;
-struct rcba_config_instruction;
-struct romstage_params {
-	struct pei_data *pei_data;
-	const void *gpio_map;
-	const struct rcba_config_instruction *rcba_config;
-	void (*copy_spd)(struct pei_data *);
-};
-void romstage_common(const struct romstage_params *params);
-
 /* Lock MSRs */
 void intel_cpu_haswell_finalize_smm(void);
 

src/northbridge/intel/haswell/Makefile.inc

@@ -14,6 +14,7 @@ ramstage-y += minihd.c
 
 romstage-y += memmap.c
 romstage-y += raminit.c
+romstage-y += romstage.c
 romstage-y += early_init.c
 romstage-y += report_platform.c
 

src/northbridge/intel/haswell/haswell.h

@@ -189,6 +189,16 @@
 
 void intel_northbridge_haswell_finalize_smm(void);
 
+struct pei_data;
+struct rcba_config_instruction;
+struct romstage_params {
+	struct pei_data *pei_data;
+	const void *gpio_map;
+	const struct rcba_config_instruction *rcba_config;
+	void (*copy_spd)(struct pei_data *peid);
+};
+void romstage_common(const struct romstage_params *params);
+
 void haswell_early_initialization(void);
 void haswell_late_initialization(void);
 void set_translation_table(int start, int end, u64 base, int inc);

src/northbridge/intel/haswell/romstage.c

@@ -7,11 +7,11 @@
 #include <cbmem.h>
 #include <commonlib/helpers.h>
 #include <romstage_handoff.h>
+#include <cpu/intel/haswell/haswell.h>
 #include <northbridge/intel/haswell/haswell.h>
 #include <northbridge/intel/haswell/raminit.h>
 #include <southbridge/intel/lynxpoint/pch.h>
 #include <southbridge/intel/lynxpoint/me.h>
-#include "haswell.h"
 
 void romstage_common(const struct romstage_params *params)
 {