GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/cbfstool: Close file on error 

Prevents a resource leak.

Change-Id: I032227228c8e37e989960ad6292ded39b81835a9
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1383919
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33992
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Jacob Garber 2019-07-02 17:50:59 -06:00 committed by Patrick Georgi
parent 509f46953e
commit 2e31ea05bb
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/cbfstool/partitioned_file.c
View File

@ -197,8 +197,10 @@ partitioned_file_t *partitioned_file_reopen(const char *filename,
const struct fmap_area *fmap_fmap_entry = const struct fmap_area *fmap_fmap_entry =
fmap_find_area(file->fmap, SECTION_NAME_FMAP); fmap_find_area(file->fmap, SECTION_NAME_FMAP);
if (!fmap_fmap_entry) if (!fmap_fmap_entry) {
partitioned_file_close(file);
return NULL; return NULL;
}
if ((long)fmap_fmap_entry->offset != fmap_region_offset) { if ((long)fmap_fmap_entry->offset != fmap_region_offset) {
ERROR("FMAP's '%s' section doesn't point back to FMAP start (did something corrupt this file?)\n", ERROR("FMAP's '%s' section doesn't point back to FMAP start (did something corrupt this file?)\n",