GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/lpc: Add lpc_disable_spi_rom_sharing 

If a Picasso platform wants to use GPIO 67 it must disable ROM sharing.
Otherwise ROM access is incredibly slow.

BUG=b:153502861
TEST=Build trembyle

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Ia9ab3803a2f56f68c1164bd241fc3917a3ffcf2b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40951
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Raul E Rangel 2020-05-01 14:04:08 -06:00 committed by Patrick Georgi
parent 65cc80f740
commit 314c716aff
3 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/amd/common/block/include/amdblocks/lpc.h
View File

@ -10,6 +10,8 @@
/* PCI registers for D14F3 */ /* PCI registers for D14F3 */
#define LPC_PCI_CONTROL 0x40 #define LPC_PCI_CONTROL 0x40
#define LEGACY_DMA_EN BIT(2) #define LEGACY_DMA_EN BIT(2)
#define VW_ROM_SHARING_EN BIT(3)
#define EXT_ROM_SHARING_EN BIT(4)
#define LPC_IO_PORT_DECODE_ENABLE 0x44 #define LPC_IO_PORT_DECODE_ENABLE 0x44
#define DECODE_ENABLE_PARALLEL_PORT0 BIT(0) #define DECODE_ENABLE_PARALLEL_PORT0 BIT(0)
@ -148,6 +150,7 @@ void lpc_tpm_decode(void);
void lpc_tpm_decode_spi(void); void lpc_tpm_decode_spi(void);
void lpc_enable_rom(void); void lpc_enable_rom(void);
void lpc_enable_spi_prefetch(void); void lpc_enable_spi_prefetch(void);
void lpc_disable_spi_rom_sharing(void);
/** /**
* @brief Find the size of a particular wide IO * @brief Find the size of a particular wide IO

6
src/soc/amd/common/block/lpc/Kconfig
View File

@ -3,3 +3,9 @@ config SOC_AMD_COMMON_BLOCK_LPC
default n default n
help help
Select this option to use the traditional LPC-ISA bridge at D14F3. Select this option to use the traditional LPC-ISA bridge at D14F3.
config PROVIDES_ROM_SHARING
bool
default n
help
Select this option if the LPC bridge supports ROM sharing.

14
src/soc/amd/common/block/lpc/lpc_util.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* This file is part of the coreboot project. */ /* This file is part of the coreboot project. */
#include <assert.h>
#include <stdint.h> #include <stdint.h>
#include <device/device.h> #include <device/device.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
@ -300,6 +301,19 @@ void lpc_enable_spi_prefetch(void)
pci_write_config32(_LPCB_DEV, LPC_ROM_DMA_EC_HOST_CONTROL, dword); pci_write_config32(_LPCB_DEV, LPC_ROM_DMA_EC_HOST_CONTROL, dword);
} }
void lpc_disable_spi_rom_sharing(void)
{
u8 byte;
if (!CONFIG(PROVIDES_ROM_SHARING))
dead_code();
byte = pci_read_config8(_LPCB_DEV, LPC_PCI_CONTROL);
byte &= ~VW_ROM_SHARING_EN;
byte &= ~EXT_ROM_SHARING_EN;
pci_write_config8(_LPCB_DEV, LPC_PCI_CONTROL, byte);
}
uintptr_t lpc_get_spibase(void) uintptr_t lpc_get_spibase(void)
{ {
u32 base; u32 base;