GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/acp: rename acp_update32 mask parameters 

The name of the and_mask parameter was a bit misleading, due to the
function inverting the value. Renaming this into clear and set makes it
more obvious what those parameters will actually do.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: If307ab4858541861e22f8ff24ed178d47ba70fe5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52524
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-04-20 00:38:32 +02:00 committed by Marshall Dawson
parent c893197352
commit 349a145299
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/amd/picasso/acp.c
View File

@ -15,13 +15,13 @@
#include <amdblocks/acpimmio.h> #include <amdblocks/acpimmio.h>
#include <commonlib/helpers.h> #include <commonlib/helpers.h>
static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t and_mask, uint32_t or_mask) static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set)
{ {
uint32_t val; uint32_t val;
val = read32((void *)(bar + reg)); val = read32((void *)(bar + reg));
val &= ~and_mask; val &= ~clear;
val |= or_mask; val |= set;
write32((void *)(bar + reg), val); write32((void *)(bar + reg), val);
} }