GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/hatch: Clean up gpio definitions in hatch variant 

This implementation cleans up gpio configuration functions
and limit definition to baseboard only for now, until variant
specfic overides are needed.

BUG=b:120914069
TEST=USE="-intel_mrc -bmpblk" emerge-hatch coreboot

Change-Id: I563f6b97812b32d6e3d99e3df512dc112da78aea
Signed-off-by: Aamir Bohra <aamir.bohra@intel.com>
Reviewed-on: https://review.coreboot.org/c/30291
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Aamir Bohra 2018-12-18 15:46:28 +05:30 committed by Subrata Banik
parent 42d1660e4e
commit 368598198d
5 changed files with 4 additions and 72 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/hatch/ramstage.c
View File

@ -24,7 +24,7 @@ void mainboard_silicon_init_params(FSP_S_CONFIG *params)
const struct pad_config *gpio_table;
size_t num_gpios;
gpio_table = variant_base_gpio_table(&num_gpios);
gpio_table = variant_gpio_table(&num_gpios);
gpio_configure_pads(gpio_table, num_gpios);
}

11
src/mainboard/google/hatch/variants/baseboard/gpio.c
View File

@ -21,24 +21,17 @@
static const struct pad_config gpio_table[] = {
};
const struct pad_config *__weak variant_base_gpio_table(size_t *num)
const struct pad_config *__weak variant_gpio_table(size_t *num)
{
*num = ARRAY_SIZE(gpio_table);
return gpio_table;
}
const struct pad_config *__weak variant_override_gpio_table(size_t *num)
{
*num = 0;
return NULL;
}
/* GPIOs needed prior to ramstage. */
static const struct pad_config early_gpio_table[] = {
};
const struct pad_config *__weak
variant_early_gpio_table(size_t *num)
const struct pad_config *__weak variant_early_gpio_table(size_t *num)
{
*num = ARRAY_SIZE(early_gpio_table);
return early_gpio_table;

8
src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
View File

@ -22,10 +22,8 @@
/* The next set of functions return the gpio table and fill in the number of
* entries for each table. */
const struct pad_config *variant_base_gpio_table(size_t *num);
const struct pad_config *variant_override_gpio_table(size_t *num);
const struct pad_config *variant_gpio_table(size_t *num);
const struct pad_config *variant_early_gpio_table(size_t *num);
const struct pad_config *variant_sleep_gpio_table(size_t *num, int slp_typ);
/* Return memory SKU for the board. */
size_t variant_memory_sku(void);
@ -33,8 +31,4 @@ size_t variant_memory_sku(void);
/* Return ChromeOS gpio table and fill in number of entries. */
const struct cros_gpio *variant_cros_gpios(size_t *num);
/* Modify devictree settings during ramstage. */
struct device;
void variant_update_devtree(struct device *dev);
#endif /* BASEBOARD_VARIANTS_H */

17
src/mainboard/google/hatch/variants/hatch/Makefile.inc
View File

@ -1,17 +0,0 @@
##
## This file is part of the coreboot project.
##
## Copyright 2018 Google LLC
##
## This program is free software; you can redistribute it and/or modify
## it under the terms of the GNU General Public License as published by
## the Free Software Foundation; version 2 of the License.
##
## This program is distributed in the hope that it will be useful,
## but WITHOUT ANY WARRANTY; without even the implied warranty of
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
## GNU General Public License for more details.
##
bootblock-y += gpio.c
ramstage-y += gpio.c

38
src/mainboard/google/hatch/variants/hatch/gpio.c
View File

@ -1,38 +0,0 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2018 Google LLC
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
* GNU General Public License for more details.
*/
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
#include <commonlib/helpers.h>
/* Pad configuration in ramstage */
static const struct pad_config gpio_table[] = {
};
/* Early pad configuration in bootblock */
static const struct pad_config early_gpio_table[] = {
};
const struct pad_config *variant_base_gpio_table(size_t *num)
{
*num = ARRAY_SIZE(gpio_table);
return gpio_table;
}
const struct pad_config *variant_early_gpio_table(size_t *num)
{
*num = ARRAY_SIZE(early_gpio_table);
return early_gpio_table;
}