GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/bd82x6x/sata.c: Replace bad uses of `find_resource` 

The `find_resource` function will never return null (will die instead).
Given that the existing code gracefully handles null pointers already,
it is reasonable to replace these function calls with `probe_resource`.

Change-Id: Ibd8f5ebd561cbde22ce5cd83de8270177bad1344
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47101
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Angel Pons 2020-11-02 13:40:11 +01:00
parent bf355e7159
commit 3d8b6e25bb
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/southbridge/intel/bd82x6x/sata.c
View File

@ -40,28 +40,28 @@ static void sata_read_resources(struct device *dev)
if (sata_mode != 2)
return;
res = find_resource(dev, PCI_BASE_ADDRESS_0);
res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (res) {
res->base = 0x1f0;
res->size = 8;
res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}
res = find_resource(dev, PCI_BASE_ADDRESS_1);
res = probe_resource(dev, PCI_BASE_ADDRESS_1);
if (res) {
res->base = 0x3f4;
res->size = 4;
res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}
res = find_resource(dev, PCI_BASE_ADDRESS_2);
res = probe_resource(dev, PCI_BASE_ADDRESS_2);
if (res) {
res->base = 0x170;
res->size = 8;
res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}
res = find_resource(dev, PCI_BASE_ADDRESS_3);
res = probe_resource(dev, PCI_BASE_ADDRESS_3);
if (res) {
res->base = 0x374;
res->size = 4;
@ -77,7 +77,7 @@ static void sata_set_resources(struct device *dev)
if (sata_mode == 2) {
unsigned int i;
for (i = PCI_BASE_ADDRESS_0; i <= PCI_BASE_ADDRESS_3; i += 4) {
struct resource *const res = find_resource(dev, i);
struct resource *const res = probe_resource(dev, i);
if (res)
res->flags &= ~IORESOURCE_FIXED;
}