GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/ifdtool: Add lock support for CNL and ICL 

Cannonlake and Icelake have same read/write region permission settings
with skylake and kabylake, so add it here as well.

BUG=b:123199222
TEST=Turn on CONFIG_LOCK_MANAGEMENT_ENGINE and build image, check the
setting matches 0x0D for read and 0x04 for write.

Signed-off-by: Lijian Zhao <lijian.zhao@intel.com>
Change-Id: I71d8b815c7dff7dcbcff2bf77c85ebf80b8df6d2
Reviewed-on: https://review.coreboot.org/c/31104
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Lijian Zhao 2019-01-25 23:20:16 -08:00 committed by Patrick Georgi
parent 06ca4c5209
commit 3e88b18bb6
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/ifdtool/ifdtool.c
View File

@ -965,6 +965,8 @@ static void lock_descriptor(const char *filename, char *image, int size)
/* TXE can only write Device Expansion */ /* TXE can only write Device Expansion */
fmba->flmstr2 |= 0x20 << wr_shift; fmba->flmstr2 |= 0x20 << wr_shift;
break; break;
case PLATFORM_CNL:
case PLATFORM_ICL:
case PLATFORM_SKLKBL: case PLATFORM_SKLKBL:
/* CPU/BIOS can read descriptor, BIOS and GbE. */ /* CPU/BIOS can read descriptor, BIOS and GbE. */
fmba->flmstr1 |= 0xb << rd_shift; fmba->flmstr1 |= 0xb << rd_shift;