GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/starlabs/*/Kconfig: Fix default power state after failure 

POWER_STATE_OFF_AFTER_FAILURE can't be directly selected since it's a
choice, so instead set POWER_STATE_DEFAULT_ON_AFTER_FAILURE to n, as
it's functionally equivalent. This fixes the warnings generated by
the pre-commit hook Kconfig check.

It is necessary to override and set default n in the mainboard Kconfig
as it is set to default y in src/soc/intel/common/block/pmc/Kconfig.

TEST=select starlabs/starbook_adl in menuconfig and verify the default
power-on setting is S5/soft off.

Change-Id: I3ce33517dcc0af693b8db8d1de2926117ad3c16b
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78627
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
Matt DeVillier 2023-10-24 17:06:18 -05:00 committed by Sean Rhodes
parent 10201aa99d
commit 434928c3a4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/starlabs/lite/Kconfig
View File

@ -71,8 +71,8 @@ config MAINBOARD_SMBIOS_PRODUCT_NAME
string string
default "Lite" default "Lite"
config POWER_STATE_OFF_AFTER_FAILURE config POWER_STATE_DEFAULT_ON_AFTER_FAILURE
default y default n
config TRACKPAD_INTERRUPT config TRACKPAD_INTERRUPT
hex hex

4
src/mainboard/starlabs/starbook/Kconfig
View File

@ -159,8 +159,8 @@ config ME_BIN_PATH
default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/\$(CONFIG_VARIANT_DIR)/intel_me.bin" default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/\$(CONFIG_VARIANT_DIR)/intel_me.bin"
config POWER_STATE_OFF_AFTER_FAILURE config POWER_STATE_DEFAULT_ON_AFTER_FAILURE
default y default n
config EDK2_BOOTSPLASH_FILE config EDK2_BOOTSPLASH_FILE
string string