GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/reef: Set touchpad/screen IRQs to LEVEL vs EDGE 

The GPIOs themselves are configured as level triggered, and the drivers
(both Linux and Windows) work better with LEVEL vs EDGE triggering.

TEST=tested with rest of patch train

Change-Id: I1000df10eea5670bf1bc8d04c736150b6a5e26a1
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71153
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Matt DeVillier 2022-12-20 16:31:51 -06:00 committed by Martin L Roth
parent beb58a93cf
commit 48894ea620
5 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/reef/variants/baseboard/devicetree.cb
View File

@ -188,7 +188,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "20"
@ -202,7 +202,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "wake" = "GPE0_DW1_15"
register "detect" = "1"
device i2c 15 on end

6
src/mainboard/google/reef/variants/coral/devicetree.cb
View File

@ -188,7 +188,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "20"
@ -200,7 +200,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "1"
@ -214,7 +214,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "wake" = "GPE0_DW1_15"
register "detect" = "1"
device i2c 15 on end

4
src/mainboard/google/reef/variants/pyro/devicetree.cb
View File

@ -211,7 +211,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "20"
@ -225,7 +225,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "wake" = "GPE0_DW1_15"
register "detect" = "1"
device i2c 15 on end

4
src/mainboard/google/reef/variants/sand/devicetree.cb
View File

@ -184,7 +184,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "20"
@ -198,7 +198,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "wake" = "GPE0_DW1_15"
register "detect" = "1"
device i2c 15 on end

8
src/mainboard/google/reef/variants/snappy/devicetree.cb
View File

@ -193,7 +193,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "20"
@ -205,7 +205,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""MLFS0000""
register "desc" = ""Melfas Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
# Melfas TS IC doesn't have reset pin design, current FW also not
# declare "ce-gpios" in ACPI _DSD to let Melfas TS driver to know
@ -226,7 +226,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "1"
@ -268,7 +268,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "wake" = "GPE0_DW1_15"
register "detect" = "1"
device i2c 15 on end